Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify delegation_pool #21

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Unify delegation_pool #21

merged 2 commits into from
Jul 5, 2024

Conversation

axiongsupra
Copy link

This is experimental feature and require discussion.

@axiongsupra axiongsupra requested a review from sjoshisupra June 29, 2024 22:33
sjoshisupra
sjoshisupra requested changes Jul 1, 2024
View reviewed changes
Copy link

@sjoshisupra sjoshisupra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests so that PBO users along with normal users are present, adding stake, remove stake and appropriate restrictions still apply for PBO users and their balances remain as expected in the pool.

@axiongsupra axiongsupra requested a review from sjoshisupra July 3, 2024 03:44
@axiongsupra axiongsupra merged commit 2449d1c into integrate_consensus_key Jul 5, 2024
0 of 2 checks passed
@axiongsupra axiongsupra deleted the temp-one-delegation-pool branch July 5, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjoshisupra sjoshisupra sjoshisupra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axiongsupra @sjoshisupra