Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose a command that amalgamates cmd+test+archive-logs #24

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Propose a command that amalgamates cmd+test+archive-logs #24

wants to merge 1 commit into from

Conversation

amenonsen
Copy link
Contributor

No description provided.

@amenonsen amenonsen requested a review from a team as a code owner September 11, 2023 04:55
@amenonsen amenonsen added the rfc label Sep 11, 2023
haroon-github
haroon-github reviewed Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@haroon-github haroon-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sounds like a very useful improvement for debugging and diagnostics. Testing could also benefit from it.

martinmarques
martinmarques reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@martinmarques martinmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this idea.

Maybe set the PR as a draft for now :)

rfcs/store-results.md
and `tpaexec playbook` executes playbooks.

* `tpaexec test` and other commands like `archive-logs` already know how
to copy things from the instances and store them in local directories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to copy things from the instances and store them in local directories
to copy things from the instances and store them in local directories.

@gonzalemario gonzalemario marked this pull request as draft August 27, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haroon-github haroon-github haroon-github left review comments

@martinmarques martinmarques martinmarques left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
rfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amenonsen @martinmarques @haroon-github