Switched add_commit_scope to create_commit_scope and added reference notes #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notes Signed-off-by: Dj Walker-Morgan <[email protected]>
…o examples changed. Signed-off-by: Dj Walker-Morgan <[email protected]>
djw-m
force-pushed
the
docs/pgd/fix/add-to-create-commit-scope
branch
from
8123d78 to
8f8cfda
Compare
djw-m
added
the
deploy
github-actions
bot
temporarily deployed
to
pr-6251-docs-pgd-fix-add-to-create-commit-scope
irionr
reviewed
Nov 19, 2024
| @@ -1157,23 +1165,27 @@ bdr.alter_commit_scope( | |||
|
|
|||
| #### Note | |||
|
|
|||
| When using `bdr.add_commit_scope`, if a new commit scope is added that has the | |||
| When using `bdr.create_commit_scope`, if a new commit scope is added that has the | |||
There was a problem hiding this comment.
Also here, only add_commit_scope makes the alter underneath.
github-actions
bot
temporarily deployed
to
pr-6251-docs-pgd-fix-add-to-create-commit-scope
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dj Walker-Morgan [email protected]
What Changed?
Fixed all add_commit_scope references to create_commit_scope references.
(No functional change in command)
Update: Sideeffect removed in create_commit_scope so no silent overwriting.