Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotNET: added page for nested table support #6226

Merged
merged 5 commits into from
Nov 19, 2024
Merged

dotNET: added page for nested table support #6226

merged 5 commits into from
Nov 19, 2024

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Nov 11, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner November 11, 2024 16:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-6226--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-6226-dotnet-tableof November 11, 2024 16:56 Inactive
@gvasquezvargas gvasquezvargas marked this pull request as draft November 12, 2024 08:04
@github-actions github-actions bot temporarily deployed to pr-6226-dotnet-tableof November 12, 2024 13:38 Inactive
xfischer
xfischer suggested changes Nov 12, 2024
View reviewed changes
Copy link

@xfischer xfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @gvasquezvargas !

product_docs/docs/net_connector/8.0.5.1/index.mdx Outdated Show resolved Hide resolved
product_docs/docs/net_connector/8.0.5.1/using_nested_table_types.mdx Outdated Show resolved Hide resolved
product_docs/docs/net_connector/8.0.5.1/using_nested_table_types.mdx Outdated Show resolved Hide resolved
product_docs/docs/net_connector/8.0.5.1/using_nested_table_types.mdx Outdated Show resolved Hide resolved
product_docs/docs/net_connector/8.0.5.1/using_nested_table_types.mdx Show resolved Hide resolved
@gvasquezvargas gvasquezvargas marked this pull request as ready for review November 12, 2024 15:48
@github-actions github-actions bot temporarily deployed to pr-6226-dotnet-tableof November 12, 2024 15:51 Inactive
@xfischer
Copy link

LGTM, Thanks a lot Gaby!

@github-actions github-actions bot temporarily deployed to pr-6226-dotnet-tableof November 18, 2024 11:53 Inactive
nidhibhammar
nidhibhammar approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@nidhibhammar nidhibhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some suggestions. You can implement them if you think they make sense.

@gvasquezvargas gvasquezvargas merged commit 9b536ce into connectors_nov_release Nov 19, 2024
3 checks passed
@gvasquezvargas gvasquezvargas deleted the dotnet/tableof branch November 19, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidhibhammar nidhibhammar nidhibhammar approved these changes

@xfischer xfischer xfischer approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvasquezvargas @xfischer @nidhibhammar