Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse of entropy description fix #2

Closed
wants to merge 939 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
939 commits
Select commit Hold shift + click to select a range
d6e492f
Automatic changelog for PR #83033 [ci skip]
comfyorange May 7, 2024
6aa0dee
Virtual Domains now have certain areas protected from ghost role inte…
Rhials May 7, 2024
694f2e7
Automatic changelog for PR #82960 [ci skip]
comfyorange May 7, 2024
17c799f
Lootpanel: Requires 515.1635+ (#83084)
jlsnow301 May 7, 2024
f420fce
Automatic changelog for PR #83084 [ci skip]
comfyorange May 7, 2024
494f306
RD get robo knowledges (#82642)
delingar May 7, 2024
2559111
Automatic changelog for PR #82642 [ci skip]
comfyorange May 7, 2024
6700593
Spies can now use other spies' uplinks. (#82995)
Iamgoofball May 7, 2024
b755a2b
Automatic changelog for PR #82995 [ci skip]
comfyorange May 7, 2024
135bf59
fixes autochangelog erroring on an empty pr body https://github.com/t…
Kylerace May 7, 2024
39963ae
blueprints status on photographs is no longer persistent (#83093)
Fikou May 7, 2024
c3fc868
Automatic changelog for PR #83093 [ci skip]
comfyorange May 7, 2024
42ec92f
Adds a small fishing pool on metastation (#82721)
Majkl-J May 7, 2024
2253dd6
Automatic changelog for PR #82721 [ci skip]
comfyorange May 7, 2024
cf27199
Reading a photo with blueprints now requires squinting (#82984)
MrMelbert May 7, 2024
8f34a8a
Automatic changelog for PR #82984 [ci skip]
comfyorange May 7, 2024
4756ea8
Automatic changelog compile [ci skip]
actions-user May 8, 2024
0fe447e
Resting knockdown disarm immunity exploit fix (#83055)
Metekillot May 8, 2024
754b1a0
Automatic changelog for PR #83055 [ci skip]
comfyorange May 8, 2024
aa5eddb
Fix pride pin reskinning (#82920)
00-Steven May 8, 2024
23dd4ac
Automatic changelog for PR #82920 [ci skip]
comfyorange May 8, 2024
b116767
Implements dynamic scaling for spies (#82961)
MrMelbert May 8, 2024
bf27e23
Automatic changelog for PR #82961 [ci skip]
comfyorange May 8, 2024
5631fb1
Unit test for black market items. Added missing bulwark module and ja…
Ghommie May 8, 2024
053f499
Automatic changelog for PR #82972 [ci skip]
comfyorange May 8, 2024
cbf5420
Fix DNA infuser tier progression check (#83104)
MrMelbert May 8, 2024
1ed2e16
Automatic changelog for PR #83104 [ci skip]
comfyorange May 8, 2024
28eca1d
Add bump mining to mech drills (#83079)
XElectricX May 8, 2024
946860d
Fixes silicon reach @ teleporter (#83090)
jlsnow301 May 8, 2024
6fd6ebd
Pipegun updates and glowup (#83063)
necromanceranne May 8, 2024
678609e
Automatic changelog for PR #83079 [ci skip]
comfyorange May 8, 2024
44ea4b1
Automatic changelog for PR #83090 [ci skip]
comfyorange May 8, 2024
0c3fdd4
Adds slight animation to entering a portal / teleporter (#83124)
MrMelbert May 8, 2024
4869202
Automatic changelog for PR #83124 [ci skip]
comfyorange May 8, 2024
96b854a
Fixes floating pixels on railings (#83118)
AMyriad May 8, 2024
177a2ed
Quick equip no longer throws balloon alerts (#83117)
jlsnow301 May 8, 2024
9425695
Automatic changelog for PR #83118 [ci skip]
comfyorange May 8, 2024
0b9e2ae
Automatic changelog for PR #83117 [ci skip]
comfyorange May 8, 2024
8666801
Allows the Coroner's Ritual Knife to go in the Medical belt! (#83113)
DrAmazing343 May 8, 2024
6e3e5d6
Automatic changelog for PR #83113 [ci skip]
comfyorange May 8, 2024
0b0ac9f
Removes another rogue cable under a disconnected SMES on Ice Box (#83…
GoldenAlpharex May 8, 2024
dd3d28e
Automatic changelog for PR #83129 [ci skip]
comfyorange May 8, 2024
1ea1f4a
Fix cult building (#83114)
MrMelbert May 8, 2024
e3f58dc
Automatic changelog for PR #83114 [ci skip]
comfyorange May 8, 2024
4023882
Automatic changelog compile [ci skip]
actions-user May 9, 2024
136c805
Fix conveyor switches not working for cyborgs (#83121)
Echriser May 9, 2024
d62a1d9
Fixes Cursed Items wizard event (#83111)
ShizCalev May 9, 2024
65179bb
Automatic changelog for PR #83121 [ci skip]
comfyorange May 9, 2024
5cb62c1
Fixes the stomach pump surgery not actually causing vomit nor decreas…
00-Steven May 9, 2024
ae38545
Automatic changelog for PR #83111 [ci skip]
comfyorange May 9, 2024
0f5a1ac
Automatic changelog for PR #83110 [ci skip]
comfyorange May 9, 2024
e81f6cd
Gives broken/burnt grass a smoothed texture, fixes issues with smooth…
GoldenAlpharex May 9, 2024
5cf4294
Automatic changelog for PR #83128 [ci skip]
comfyorange May 9, 2024
0308430
Fixes logging runtime when admins trigger summon events (#83109)
ShizCalev May 9, 2024
3b895e4
Adds animation to objects sliding into or out of morgue trays (#83127)
MrMelbert May 9, 2024
3c51acc
Fixes masspurbation erroring out when trying to give/remove cat tails…
ShizCalev May 9, 2024
0d29902
Fixes some missing poll_ghost_candidates sanity checking for ghost ro…
ShizCalev May 9, 2024
7277fa6
Fixes deployable turrets not actually being undeployable. (#83061)
ShizCalev May 9, 2024
d0062f1
Fixes flap and wing emotes not updating wing sprites (for functional …
vinylspiders May 9, 2024
98514ed
Automatic changelog for PR #83127 [ci skip]
comfyorange May 9, 2024
ba6019d
Screentips for sm shard (#83119)
jlsnow301 May 9, 2024
98b73d5
Laser decharge sound uses pitch instead of frequency (#83102)
Jacquerel May 9, 2024
4c66974
Add alt-click usage context to toggle_icon component (#83123)
00-Steven May 9, 2024
df05285
The labour camp shuttle paroles the user when they complete their poi…
Pickle-Coding May 9, 2024
c8f35f4
Automatic changelog for PR #83137 [ci skip]
comfyorange May 9, 2024
b71ae55
Automatic changelog for PR #83119 [ci skip]
comfyorange May 9, 2024
cc37d19
Automatic changelog for PR #83102 [ci skip]
comfyorange May 9, 2024
58ff7f0
Fix space heaters always saying Auto when panel is closed (#83100)
malton33 May 9, 2024
46e6740
Automatic changelog for PR #83123 [ci skip]
comfyorange May 9, 2024
aec6c00
Automatic changelog for PR #83132 [ci skip]
comfyorange May 9, 2024
2bf5711
Command bar typing indicators (client side html version) (#83081)
MrStonedOne May 9, 2024
f358423
Replace Heretic Phobia with Cursed Organs (#83082)
Jacquerel May 9, 2024
2efd770
Fix tutorials not reappearing in some cases (#83066)
TiviPlus May 9, 2024
9526e99
The shuttle won't gib you anymore while you're in jaunt (#83134)
paganiy May 9, 2024
59a7618
Automatic changelog for PR #83100 [ci skip]
comfyorange May 9, 2024
27c8506
Automatic changelog for PR #83081 [ci skip]
comfyorange May 9, 2024
bad8b42
Automatic changelog for PR #83082 [ci skip]
comfyorange May 9, 2024
37aa1ba
Automatic changelog for PR #83066 [ci skip]
comfyorange May 9, 2024
061027d
Automatic changelog for PR #83134 [ci skip]
comfyorange May 9, 2024
e083a1c
Automatic changelog compile [ci skip]
actions-user May 10, 2024
b7d4c7f
Chance to become crab on DNA meltdown (#82985)
carlarctg May 10, 2024
92b3d61
Automatic changelog for PR #82985 [ci skip]
comfyorange May 10, 2024
17a1132
fixes fish huds hard delete (#83160)
Ben10Omintrix May 10, 2024
1fc7930
Coroner, Chief Engineer, Bitrunner are no longer exempt from certain …
norsvenska May 10, 2024
7ec391d
Automatic changelog for PR #83165 [ci skip]
comfyorange May 10, 2024
89c7a4f
Automatic changelog compile [ci skip]
actions-user May 11, 2024
b75eab1
fix glass style /hooch being duped (#83169)
Xander3359 May 11, 2024
84386f9
Automatic changelog for PR #83169 [ci skip]
comfyorange May 11, 2024
6621e94
[no gbp] fixes spy bug, thank you melbert (#83153)
Higgin May 11, 2024
7acc09b
Automatic changelog for PR #83153 [ci skip]
comfyorange May 11, 2024
cff1cb0
Adds some autodoc to sound.dm (#83148)
Xander3359 May 11, 2024
c0133e4
Reimplements node compatibility mode (#83141)
jlsnow301 May 11, 2024
ba9cb64
Tgui: More common components in ts (#83098)
jlsnow301 May 11, 2024
b535d22
Automatic changelog compile [ci skip]
actions-user May 12, 2024
c3622c3
Enables right click, alt click, ctrl click for alt-click item window …
Metekillot May 12, 2024
67a8912
Automatic changelog for PR #83179 [ci skip]
comfyorange May 12, 2024
6606fa4
Bitrunner job figurine (#83173)
Rhials May 12, 2024
400ba8e
Automatic changelog for PR #83173 [ci skip]
comfyorange May 12, 2024
1b09d8d
Rat Kings can no longer create grime and miasma while ventcrawling (#…
PapaMichae1 May 12, 2024
de25d43
Automatic changelog for PR #83176 [ci skip]
comfyorange May 12, 2024
45b403f
Fix the RMB action on the cigarettes pack and add a new QoL (#83170)
paganiy May 12, 2024
f20a080
Automatic changelog for PR #83170 [ci skip]
comfyorange May 12, 2024
2083960
Adds a period to the end of the wendigo deathrattle (#83185)
nikothedude May 12, 2024
72c92f3
Automatic changelog for PR #83185 [ci skip]
comfyorange May 12, 2024
a838d0b
Replace cigarette smoke with particles, add a big puff when taking ci…
MrMelbert May 13, 2024
4524b70
Automatic changelog for PR #83101 [ci skip]
comfyorange May 13, 2024
951f24d
Automatic changelog compile [ci skip]
actions-user May 13, 2024
547ca8f
Node Bootstrap: Cast OS version to int so compat code works (#83190)
MrStonedOne May 13, 2024
c12af14
Fixes sabre alt-click (#83162)
jlsnow301 May 13, 2024
30675c9
Automatic changelog for PR #83162 [ci skip]
comfyorange May 13, 2024
d70aa8b
Fix the size of the projectile of the accelerator laser cannon (#83144)
paganiy May 13, 2024
1e2df8b
Automatic changelog for PR #83144 [ci skip]
comfyorange May 13, 2024
bca5685
tgui: Strings.ts (#83096)
jlsnow301 May 13, 2024
28791c0
Bodybuilders can see each others' power levels. (#83088)
Jacquerel May 13, 2024
671c47f
Automatic changelog for PR #83088 [ci skip]
comfyorange May 13, 2024
013e40b
Fixes brain deletion not being lethal (#83203)
Time-Green May 13, 2024
6e794ef
Automatic changelog for PR #83203 [ci skip]
comfyorange May 13, 2024
6933307
Fixes tram malfuction event not ending properly (#83200)
ShizCalev May 13, 2024
5d81ba7
Makes Health Sensor assemblies a bit nicer to use (#83183)
May 13, 2024
8895e8d
Automatic changelog for PR #83183 [ci skip]
comfyorange May 13, 2024
2dc73fb
Automatic changelog compile [ci skip]
actions-user May 14, 2024
65fd769
Fixes arcade spawners in Interdyne Spinward Research Base (#83171)
DaCoolBoss May 14, 2024
8d81e19
Automatic changelog for PR #83171 [ci skip]
comfyorange May 14, 2024
e1ac6e4
Makes it so cargo security doesnt get stuck in mining station. (#83209)
KingkumaArt May 14, 2024
3e1889d
Automatic changelog for PR #83209 [ci skip]
comfyorange May 14, 2024
1184365
Allows status effects with alerts to display their duration (on the a…
MrMelbert May 14, 2024
6e1d6e7
Automatic changelog for PR #83211 [ci skip]
comfyorange May 14, 2024
db782b6
Fixes random decal in space on Tramstation (#83178)
iwishforducks May 14, 2024
348d69c
Automatic changelog for PR #83178 [ci skip]
comfyorange May 14, 2024
a8dda64
Moves as many db related date/time operations to the db side to avoid…
MrStonedOne May 14, 2024
d7aef14
Fixes cultist blood rites runtime (#83220)
Lufferly May 15, 2024
55d77b5
Automatic changelog for PR #83220 [ci skip]
comfyorange May 15, 2024
40c2bca
Fixes a reversion to the greyscale plate armor (#83214)
necromanceranne May 15, 2024
268cf9a
Automatic changelog for PR #83214 [ci skip]
comfyorange May 15, 2024
16be085
Fixes energy lost as heat for some machines (#83205)
SyncIt21 May 15, 2024
ca92ca4
Fixes destroyed solar panels dropping overlays (#83224)
Lufferly May 15, 2024
bfa1582
Automatic changelog compile [ci skip]
actions-user May 15, 2024
2860887
Automatic changelog for PR #83205 [ci skip]
comfyorange May 15, 2024
b825ac4
Automatic changelog for PR #83224 [ci skip]
comfyorange May 15, 2024
9affd58
Fixes kinetic accelerator fire sound div 0 runtime (#83177)
ShizCalev May 15, 2024
8b8934c
Portals now make sounds (#83166)
Sadboysuss May 15, 2024
db33f07
[NO GBP] Fixes the knife offsets of pipeguns (#83155)
necromanceranne May 15, 2024
1d1a264
Confirm Order button now active when cargo shuttle is at Central (#83…
Shadow-Quill May 15, 2024
a35e1e4
Automatic changelog for PR #83166 [ci skip]
comfyorange May 15, 2024
1f7bb38
Automatic changelog for PR #83155 [ci skip]
comfyorange May 15, 2024
7e4886c
Automatic changelog for PR #83152 [ci skip]
comfyorange May 15, 2024
3f73d00
allows the SC/FISHER to shoot floor lights (#83182)
Hatterhat May 15, 2024
183bd6b
Fixes minor runtime when borgs get qdeleted (#83221)
ShizCalev May 15, 2024
a0a51c5
Ensures kinetic accelerators always get their mods added to the modki…
ShizCalev May 15, 2024
4a1cb19
Automatic changelog for PR #83182 [ci skip]
comfyorange May 15, 2024
7017305
Automatic changelog for PR #83222 [ci skip]
comfyorange May 15, 2024
fce5209
Fixes some bitrunning related issues [no gbp] (#83184)
jlsnow301 May 15, 2024
9748ccd
Automatic changelog for PR #83184 [ci skip]
comfyorange May 15, 2024
261548f
Staff of Shrinking for the wizard (#83115)
PKPenguin321 May 15, 2024
d942da7
Blood Brothers admin tooling (#83130)
Jacquerel May 15, 2024
ca8dcc2
Automatic changelog for PR #83115 [ci skip]
comfyorange May 15, 2024
df3d409
Automatic changelog for PR #83130 [ci skip]
comfyorange May 15, 2024
4b174e4
Adds a new neutral lawset, the Y.E.S.M.A.N. lawset, to the AI lawset …
Iamgoofball May 15, 2024
7499b84
Protects space spawned humans from radiation nebula (#83202)
Time-Green May 15, 2024
db6ce47
Adds -y to upgrade in the docker files to prevent breakage (#83198)
DaxDupont May 15, 2024
1ea3cfc
The Shovellening: Coroner and Miner Coats can now hold Shovels (#83139)
DrAmazing343 May 15, 2024
0ab70e4
Automatic changelog for PR #83202 [ci skip]
comfyorange May 15, 2024
f0e8ee6
Adds more box types to cardboard crafting (#83135)
Derpguy3 May 15, 2024
45dfe7d
Automatic changelog for PR #83198 [ci skip]
comfyorange May 15, 2024
6712682
Automatic changelog for PR #83139 [ci skip]
comfyorange May 15, 2024
25eae99
Automatic changelog for PR #83135 [ci skip]
comfyorange May 15, 2024
d06d92b
General maintenance for smoke machine (#83158)
SyncIt21 May 15, 2024
737f571
Blade creation ritual returns lost blades (#82592)
Xackii May 15, 2024
95b3cfa
Automatic changelog for PR #83158 [ci skip]
comfyorange May 15, 2024
066815a
The armoury contraband locker guns have a chance to be rigged. (#83167)
Pickle-Coding May 15, 2024
32ff8d1
Automatic changelog for PR #83167 [ci skip]
comfyorange May 15, 2024
e143e52
Moves the departmental delivery area check to a unit test so it stops…
Majkl-J May 15, 2024
1133e90
Shift-clicking an offer for an item will examine the item (#83180)
MrMelbert May 15, 2024
e12e3df
Automatic changelog for PR #83180 [ci skip]
comfyorange May 15, 2024
b5f6b04
parrots try to immitate voices (#82773)
Ben10Omintrix May 15, 2024
1946ba1
Automatic changelog for PR #82773 [ci skip]
comfyorange May 15, 2024
53518e0
Circuit editor QoL and new circuit components (#82969)
tmyqlfpir May 15, 2024
84472cb
[no gbp] Fixes uniform alt click while resting (#83231)
jlsnow301 May 15, 2024
ae64cae
Automatic changelog for PR #82969 [ci skip]
comfyorange May 15, 2024
b832885
Automatic changelog for PR #83231 [ci skip]
comfyorange May 15, 2024
428c594
Automatic changelog compile [ci skip]
actions-user May 16, 2024
926f819
Remove sleeper protocol objective + Remove the upper limit to sabotag…
Xander3359 May 16, 2024
150418d
Automatic changelog for PR #83206 [ci skip]
comfyorange May 16, 2024
2d5f448
Assorted minor alt-click reskinning fixes, primarily context-based (#…
00-Steven May 16, 2024
e55f24b
Automatic changelog for PR #83105 [ci skip]
comfyorange May 16, 2024
ec41cba
Fixes wings working in space (#83239)
Lufferly May 16, 2024
fb7e9fc
Automatic changelog for PR #83239 [ci skip]
comfyorange May 16, 2024
125d637
Fixes some atoms conduct electricity flag (#83230)
RengaN02 May 16, 2024
40ca497
Automatic changelog for PR #83230 [ci skip]
comfyorange May 16, 2024
1904409
Neckties can be worn below suits and accessories (#83131)
siliconOpossum May 16, 2024
a8fc20d
Automatic changelog for PR #83131 [ci skip]
comfyorange May 16, 2024
091e3af
Restores Balance to the Candle Economy (#83240)
Thunder12345 May 16, 2024
501c8c7
Automatic changelog for PR #83240 [ci skip]
comfyorange May 16, 2024
650492a
Fixes Spess Knife's cutter tool having an invisible sprite (#83246)
May 16, 2024
e364c3e
Automatic changelog for PR #83246 [ci skip]
comfyorange May 16, 2024
f70350c
Fixes simplebot ui [no gbp] (#83235)
jlsnow301 May 16, 2024
6f9f3cf
Automatic changelog for PR #83235 [ci skip]
comfyorange May 16, 2024
77e739a
Cargo goodies section typo fix (#83245)
May 16, 2024
959477c
Atoms that are on the border of a tile will now only trigger landmine…
ShizCalev May 16, 2024
e8b834c
Automatic changelog for PR #83245 [ci skip]
comfyorange May 16, 2024
c0e5e32
Automatic changelog for PR #83156 [ci skip]
comfyorange May 16, 2024
03db803
Parse_zone audit + minor misc cleanup (#83154)
nikothedude May 16, 2024
ffd227c
Automatic changelog for PR #83154 [ci skip]
comfyorange May 16, 2024
74f52a7
Fixes cyborg omnitool combat behaviour. (#83243)
Pickle-Coding May 16, 2024
5a3d67a
Automatic changelog for PR #83243 [ci skip]
comfyorange May 16, 2024
d93d19c
mobile defibrillator mount (#83000)
mc-oofert May 16, 2024
1faa23b
Automatic changelog for PR #83000 [ci skip]
comfyorange May 16, 2024
4264919
Fix radiation not causing mutations or making you bald (3 year old bu…
MrMelbert May 16, 2024
0e12079
Automatic changelog for PR #83251 [ci skip]
comfyorange May 16, 2024
1548372
Rust Heretic rework: THE PUKENING. (#83006)
EnterTheJake May 16, 2024
6e36398
Automatic changelog for PR #83006 [ci skip]
comfyorange May 16, 2024
5dc5ccd
Fixes missing scrubber pipes on metastation (#83232)
improvedname May 16, 2024
a051994
Automatic changelog for PR #83232 [ci skip]
comfyorange May 16, 2024
a3940a4
Updates to orbit ui [READY] (#83186)
jlsnow301 May 16, 2024
a50e2cd
Automatic changelog for PR #83186 [ci skip]
comfyorange May 16, 2024
f1a22b3
Changes how lube crawling works and fixes a bug with snails (#83238)
JohnFulpWillard May 16, 2024
10b2af4
Automatic changelog for PR #83238 [ci skip]
comfyorange May 16, 2024
2edb3af
Automatic changelog compile [ci skip]
actions-user May 17, 2024
761b14e
lavaland raptors (#82537)
Ben10Omintrix May 17, 2024
0e63413
Automatic changelog for PR #82537 [ci skip]
comfyorange May 17, 2024
c79cedc
Fixes Space Phase softlock (#83241)
Absolucy May 17, 2024
4c79bd5
Automatic changelog for PR #83241 [ci skip]
comfyorange May 17, 2024
74efdd3
Adds Minecarts (#83175)
MrMelbert May 17, 2024
ee0d5f3
Automatic changelog for PR #83175 [ci skip]
comfyorange May 17, 2024
225562b
Cancel CI on new commit (#83255)
jlsnow301 May 17, 2024
55f4249
fixes runtime when trying to remove a nonexistent source ID via Remov…
ShizCalev May 17, 2024
f70ea21
Fixes a bunch of hearts becoming errors when being eaten (#83259)
Echriser May 17, 2024
31c13fd
Automatic changelog for PR #83259 [ci skip]
comfyorange May 17, 2024
eb5ac96
Upgrades nukies ordnance by adding more gasses and better stock parts…
improvedname May 17, 2024
83d0154
Automatic changelog for PR #83233 [ci skip]
comfyorange May 17, 2024
f0f026d
Standardises name of The Lizard's Gas (Lava) (#83250)
DaCoolBoss May 17, 2024
868c85c
Fixes Malf AI not being able to override/overload turrets that have c…
ShizCalev May 17, 2024
df6939f
Automatic changelog for PR #83250 [ci skip]
comfyorange May 17, 2024
7684168
Automatic changelog for PR #83252 [ci skip]
comfyorange May 17, 2024
cd9e9dc
Tgui: Events & Colors in typescript (#83218)
jlsnow301 May 17, 2024
14e27ec
adds the Ansem/SC, the logical conclusion to the John Splintercell se…
Hatterhat May 17, 2024
0612a49
Automatic changelog for PR #83228 [ci skip]
comfyorange May 17, 2024
e81a94d
Malf AI overload blacklists (#83226)
Sadboysuss May 17, 2024
715d61f
Automatic changelog for PR #83226 [ci skip]
comfyorange May 17, 2024
d83bf4f
Suit sensors can now be quick-maxed by ctrl clicking (#83265)
Sadboysuss May 17, 2024
8ebef95
Automatic changelog for PR #83265 [ci skip]
comfyorange May 17, 2024
de11d2b
[Icebox] Retvrn: Brings Bar Back to Base (level) (#83163)
MrMelbert May 17, 2024
d6d8103
Automatic changelog for PR #83163 [ci skip]
comfyorange May 17, 2024
d37779e
Micro-optimizes _SendSignal a bit (#83244)
Watermelon914 May 17, 2024
0ae4675
Mobs spawners won't spawn more mobs than they are supposed to (#83266)
Jacquerel May 17, 2024
3291b81
Automatic changelog for PR #83266 [ci skip]
comfyorange May 17, 2024
6e258c9
Pulse Of Entropy-fix-typo
EnterTheJake May 17, 2024
2c9d221
merge-conflicts-fix
EnterTheJake May 17, 2024
3f8a582
Merge branch 'master' into PulseOfEntropy-Description-Fix
EnterTheJake May 18, 2024
61b2854
Revert "merge-conflicts-fix"
EnterTheJake May 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
22 changes: 22 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# http://editorconfig.org
root = true

[*]
indent_style = tab
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.yml]
indent_style = space
indent_size = 2

[*.py]
indent_style = space

[*.md]
trim_trailing_whitespace = false

[Dockerfile]
indent_style = space
18 changes: 9 additions & 9 deletions .github/guides/HARDDELETES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Hard Deletes

> Garbage collection is pretty gothic when you think about it.
> Garbage collection is pretty gothic when you think about it.
>
>An object in code is like a ghost, clinging to its former life, and especially to the people it knew. It can only pass on and truly die when it has dealt with its unfinished business. And only when its been forgotten by everyone who ever knew it. If even one other object remembers it, it has a connection to the living world that lets it keep hanging on
>
Expand Down Expand Up @@ -52,7 +52,7 @@ This of course means they can store that location in memory in another object's

/proc/someshit(mem_location)
var/datum/some_obj = new()
some_obj.reference = mem_location
some_obj.reference = mem_location
```

But what happens when you get rid of the object we're passing around references to? If we just cleared it out from memory, everything that holds a reference to it would suddenly be pointing to nowhere, or worse, something totally different!
Expand Down Expand Up @@ -135,13 +135,13 @@ If that fails, search the object's typepath, and look and see if anything is hol
BYOND currently doesn't have the capability to give us information about where a hard delete is. Fortunately we can search for most all of then ourselves.
The procs to perform this search are hidden behind compile time defines, since they'd be way too risky to expose to admin button pressing

If you're having issues solving a harddel and want to perform this check yourself, go to `_compile_options.dm` and uncomment `TESTING`, `REFERENCE_TRACKING`, and `GC_FAILURE_HARD_LOOKUP`
If you're having issues solving a harddel and want to perform this check yourself, go to `_compile_options.dm` and uncomment `REFERENCE_TRACKING_STANDARD`.

You can read more about what each of these do in that file, but the long and short of it is if something would hard delete our code will search for the reference (This will look like your game crashing, just hold out) and print information about anything it finds to the runtime log, which you can find inside the round folder inside `/data/logs/year/month/day`
You can read more about what each of these do in that file, but the long and short of it is if something would hard delete our code will search for the reference (This will look like your game crashing, just hold out) and print information about anything it finds to [log_dir]/harddels.log, which you can find inside the round folder inside `/data/logs/year/month/day`

It'll tell you what object is holding the ref if it's in an object, or what pattern of list transversal was required to find the ref if it's hiding in a list of some sort
It'll tell you what object is holding the ref if it's in an object, or what pattern of list transversal was required to find the ref if it's hiding in a list of some sort, alongside the references remaining.

## Techniques For Fixing Hard Deletes
## Techniques For Fixing Hard Deletes

Once you've found the issue, it becomes a matter of making sure the ref is cleared as a part of Destroy(). I'm gonna walk you through a few patterns and discuss how you might go about fixing them

Expand Down Expand Up @@ -243,7 +243,7 @@ So then, we want to temporarily remember to clear a reference when it's deleted

This is where I might lose you, but we're gonna use signals

`qdel()`, the proc that sets off this whole deletion business, sends a signal called `COMSIG_PARENT_QDELETING`
`qdel()`, the proc that sets off this whole deletion business, sends a signal called `COMSIG_QDELETING`

We can listen for that signal, and if we hear it clear whatever reference we may have

Expand All @@ -255,10 +255,10 @@ Here's an example

/somemob/proc/set_target(new_target)
if(target)
UnregisterSignal(target, COMSIG_PARENT_QDELETING) //We need to make sure any old signals are cleared
UnregisterSignal(target, COMSIG_QDELETING) //We need to make sure any old signals are cleared
target = new_target
if(target)
RegisterSignal(target, COMSIG_PARENT_QDELETING, PROC_REF(clear_target)) //Call clear_target if target is ever qdel()'d
RegisterSignal(target, COMSIG_QDELETING, PROC_REF(clear_target)) //Call clear_target if target is ever qdel()'d

/somemob/proc/clear_target(datum/source)
SIGNAL_HANDLER
Expand Down
Loading
Loading