Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coven (New Faction... again....) #1245

Open
wants to merge 53 commits into
base: dev_2.2.0
Choose a base branch
from
Open

Coven (New Faction... again....) #1245

wants to merge 53 commits into from

Conversation

MargaretTheFool
Copy link
Contributor

@MargaretTheFool MargaretTheFool commented Oct 1, 2024 •
edited
Loading

this is nowhere near finished but i might as well make a pr for it
https://docs.google.com/document/d/1KaBjn6qk5NqUC7Ax7uQxXY1C9wsswWH__rBdzrZCd1I/edit?usp=sharing

@MargaretTheFool MargaretTheFool marked this pull request as draft October 1, 2024 21:47
@MargaretTheFool MargaretTheFool changed the title Happy Halloween! Coven (New Faction... again....) Oct 1, 2024
@Tommy-XL Tommy-XL added the New Role/Add-on New role added label Oct 2, 2024
@MargaretTheFool
medusa fix
752a4d0 
i think i broke necronomicon's rpc with this but im hoping that was an alpha 16 issue cuz i heard a lot of rpc issues about alpha 16
@MargaretTheFool
moon dancer
696b0ef
@MargaretTheFool
merge
24d6bcd
@Tommy-XL Tommy-XL changed the base branch from DevBuild_2.1.0 to main October 27, 2024 08:51
@MargaretTheFool
Copy link
Contributor Author

Conjurer, Coven Leader, Medusa, Moon Dancer, Ritualist, and Voodoo Master work perfectly fine
Illusionist works good but is buggy on some role interactions
Sacrifist is very buggy
Hex Master, Jinx, Necromancer, Poisoner, Potion Master have not been changed yet
Dreamweaver, Sorceress, and Spellcaster have not been coded at all yet
Sorceress was Drakos's idea that he wanted to code so that wont be touched at all.
I can't code Dreamweaver until EnhancedNetwork/TownofHost-Enhanced#1222 gets merged.
I might scrap Spellcaster
The Necronomicon Mechanic is buggy
Guessing Menu is completely broken and voting doesn't work half the time and I can't figure out why

@MargaretTheFool
Copy link
Contributor Author

i did NOT do that

@MargaretTheFool
Copy link
Contributor Author

voting and guessing dont work but everything else does as far as I know, im gonna need someone else to fix this for me
here's the proof:

Screen.Recording.2024-11-10.132412.mp4

TOHE-v2024.1103.211.9999-2024-11-10_13.24.37.log

@MargaretTheFool MargaretTheFool marked this pull request as ready for review November 11, 2024 23:59
@MargaretTheFool
Copy link
Contributor Author

I fixed voting last night but I'm still not sure why the guessing menu won't populate roles

@MargaretTheFool
Copy link
Contributor Author

oh my GOD i finally fixed it it was one stupid variable

@NikoCat233 NikoCat233 changed the base branch from main to dev_2.2.0 November 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New Role/Add-on New role added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MargaretTheFool @Tommy-XL