Remove hardcoded value, use variable

[sn0ot]

Minor edit.

background-color parameter in _base.scss did not use color variables from _variables.scss and was hard coded.

$white: defined in _variables.scss was unused otherwise.

Color #fff was only used in _base.scss.

[EmielH]

Hi @sn0ot! Thanks for creating a dark theme and fixing the style that did not use a colour variable.

However, now the dark theme is the default for everyone using the theme and site creators need to edit SCSS files to be able to use the light theme. I believe it would be better if the dark theme is automatically used when users have set their OS to dark (using prefers-color-scheme) or maybe using a button to switch from dark to light themes. Alternatively, we could have the site creator choose between dark and light themes using a setting. What do you think?

[sn0ot]

Hi @EmielH ! Commit ce75773 was accidentally lumped into the pull request, how embarrassing :| The pull request is just for commit 83258b8.

I agree with you on all points . I am working towards having the dark theme configurable as a parameter that can be set in config.toml. The light theme will be default if no parameter is added. Automatically adjusting the theme or a dongle to switch can be patched in by someone else as I'm not looking to pursue that.

What I accidentally pushed was half finished. I am just waiting now on a response to issue #45 about the code highlighting so the final pull request will account for code style. The default monokai code highlighting is alright when using the light theme, but an eyesore with the dark pallette.