"Modernization" of the plugin e.a. #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoranBrondsema
force-pushed
the
updates
branch
13 times, most recently
from
4bfbe1a to
41b894a
Compare
YoranBrondsema
force-pushed
the
updates
branch
from
41b894a to
1e0dd0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm deploying an Ember.js with Fastboot on Google Cloud Platform so started using this plugin. This PR is a bunch of improvements to "modernize" the plugin.
gcloudmodule with@google-cloud/storagemodule.gcloudhas been superseded bygoogle-cloud, which has been superseded by@google-cloud/storage.yarn upgrade --latest).credentialskey inconfig/deploy.jsfor GCP credentials.There are no automated tests but I deployed on Google Cloud Platform using this branch and it works. I plan on adding automated tests at a later point.