Error handling #107
Error handling #107
Conversation
Woody4618
commented
Dec 9, 2024
Woody4618
commented
- Add priority fee parameter to upload so that it is more reliable
- Fixed the abort signal so that its possible to stop the --remote command
- Added as skip build parameter to verify-from-repo so that one does not have to wait until the build is done to upload the on chain data. For example in case the upload fails or there is some other error in between
- Check if program is actually deployed on the current cluster and show an error if it is not
- Handle error when program is not deployed
| .arg(Arg::with_name("skip-build") | ||
| .long("skip-build") | ||
| .help("Skip building and verification, only upload the PDA") | ||
| .takes_value(false))) |
There was a problem hiding this comment.
This is what solana-verify remote submit-job is for
There was a problem hiding this comment.
I added this so that you can easily skip the first step of this command and directly go to the PDA upload. Submit job does trigger the remote job not the PDA upload.
There was a problem hiding this comment.
Okay this makes sense.
verify-from-repo --remote will now trigger write to PDA & submit job, skipping build
| if remote { | ||
| let genesis_hash = get_genesis_hash(connection)?; | ||
| if genesis_hash != MAINNET_GENESIS_HASH { | ||
| return Err(anyhow!("Remote verification only works with mainnet. Please omit the --remote flag to verify locally.")); | ||
| } |
There was a problem hiding this comment.
Why is this entire block getting deleted?
There was a problem hiding this comment.
It was duplicate code exactly the same as 100 lines below. Both code paths now use the same args logic. Was added here: a8ea0ce
There was a problem hiding this comment.
I think you forgot to add this get_genesis_hash check back in
There was a problem hiding this comment.
Its still there, no? In line 1140
There was a problem hiding this comment.
You're right! Looks good to me
| .arg(Arg::with_name("skip-build") | ||
| .long("skip-build") | ||
| .help("Skip building and verification, only upload the PDA") | ||
| .takes_value(false))) |
There was a problem hiding this comment.
Okay this makes sense.
verify-from-repo --remote will now trigger write to PDA & submit job, skipping build
| if remote { | ||
| let genesis_hash = get_genesis_hash(connection)?; | ||
| if genesis_hash != MAINNET_GENESIS_HASH { | ||
| return Err(anyhow!("Remote verification only works with mainnet. Please omit the --remote flag to verify locally.")); | ||
| } |
There was a problem hiding this comment.
I think you forgot to add this get_genesis_hash check back in
|
Looking at this again, I think this may also solve an error that occurs if you attempt to run This error will be thrown when attempting to fill --library-name when none is provided. We attempt to run Would appreciate if you could check that |
