Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dxCompiler #162

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Add support for dxCompiler #162

wants to merge 9 commits into from

Conversation

jdidion
Copy link
Collaborator

@jdidion jdidion commented Feb 22, 2021 •
edited
Loading

dxCompiler still has the same CLI as dxWDL, so we support both using the same base executor.

@jdidion jdidion requested a review from haaskyle August 24, 2021 17:37
@haaskyle
Copy link
Contributor

I checked out the branch at commit e1cf73f and I just completed a test run for pytestwdl with the executor dxcompiler. The test passed! I used the example workflow found on the main Github page for dxCompiler.

@haaskyle
Copy link
Contributor

haaskyle commented Aug 26, 2021 •
edited
Loading

Minor suggestion: Should this now state dxwdl and dxcompiler executor?

pytest-wdl/pytest_wdl/providers/dx.py

Line 222 in f957c35

"Currently, the dxWDL executor only supports executing "

roopaliup16
roopaliup16 previously approved these changes Sep 16, 2021
View reviewed changes
@roopaliup16 roopaliup16 dismissed their stale review September 16, 2021 11:20

Not intentend for reviewing

@jdidion jdidion requested a review from roopaliup16 November 1, 2021 18:30
@jdidion
Copy link
Collaborator Author

jdidion commented Nov 1, 2021

@haaskyle please review

haaskyle
haaskyle previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@haaskyle haaskyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haaskyle haaskyle haaskyle left review comments

@michaeltneylon michaeltneylon Awaiting requested review from michaeltneylon

@roopaliup16 roopaliup16 Awaiting requested review from roopaliup16

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdidion @haaskyle @roopaliup16