Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

askrene: add expiration parameter to create-layer #7963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lagrang3
Copy link
Collaborator

This could be useful if we want to create one-time use layers on the flight and not worry about memory leaks (one time used layers that are not removed constitute a memory leak in a sense).

I would like to re-introduce in the pay command (xpay-handle-pay=true) the possibility of excluding channels
and nodes using the legacy pay style exclude parameter.
One possible solution is to create a one-time layer with all the channels and nodes listed in the exclude
array as disabled and then pass the call to xpay with that temporary layer in the parameters.
We make this one-time layer possible by introducing expiration times to layers in this PR.

Changelog-Added: askrene: add an optional self-destruction timer (expiration parameter) to new layers.

@Lagrang3 Lagrang3 force-pushed the askrene-self-destructing-layers branch from ca32c5f to b021d3d Compare December 20, 2024 20:00
This could be useful if we want to create one-time use layers
on the flight and not worry about memory leaks (one time used
layers that are not removed constitute a memory leak in a sense).

Changelog-Added: askrene: add an optional self-destruction timer (expiration parameter) to new layers.

Signed-off-by: Lagrang3 <[email protected]>
@Lagrang3 Lagrang3 force-pushed the askrene-self-destructing-layers branch from b021d3d to 2c2a4e6 Compare December 23, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant