xpay: more accurately reflect pay when xpay-handle-pay is set. #7938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the slight code reorder changes the JSON order, which is generally undefined, but our doc checker is very strict! Changelog-Changed: `xpay` now gives the same JSON success return as documented by `pay` when `xpay-handle-pay` is set. Signed-off-by: Rusty Russell <[email protected]> Fixes: ElementsProject#7923
rustyrussell
force-pushed
the
xpay-as-pay-add-status
branch
from
46690b3 to
9d21f6f
Compare
Lagrang3
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Changed:
xpaynow gives the same JSON success return as documented bypaywhenxpay-handle-payis set.Fixes: #7923
Fixes: #7934