Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: don't send trace messages by default, don't ratelimit at all. #7935

Merged

Conversation

rustyrussell
Copy link
Contributor

We ratelimited DEBUG messages, but that can be annoying and cause us to miss things. We demoted the worst offenders in the last release, to TRACE level.

Now, only log trace if it's wanted, and never suppress DEBUG.

Changelog-Changed: Logging: we no longer suppress DEBUG messages from subdaemons.

Fixes: #7917

We ratelimited DEBUG messages, but that can be annoying and cause us to miss things.
We demoted the worst offenders in the last release, to TRACE level.

Now, only log trace if it's wanted, and never suppress DEBUG.

Changelog-Changed: Logging: we no longer suppress DEBUG messages from subdaemons.
Signed-off-by: Rusty Russell <[email protected]>
Fixes: ElementsProject#7917
@rustyrussell rustyrussell added this to the v25.02 milestone Dec 13, 2024
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de673c7

@rustyrussell rustyrussell modified the milestones: v25.02, v24.11.1 Dec 15, 2024
@rustyrussell rustyrussell merged commit 73415d3 into ElementsProject:master Dec 15, 2024
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calc_forwarding_channel can pick a channel that is offline, leading to unilateral closure
2 participants