onionmessage forward fail notification #7903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's undocumented and only used in one place, so we can change it (it was new in 24.08). We really want to be able to just handle a raw onionmessage: this allows oblivious sending of messages, but also, in combination with the coming onionmessage_forward_fail notification, allows us to connect then reinject. Signed-off-by: Rusty Russell <[email protected]>
It's actually tested by fetchinvoice, but doing an explicit test in Python allows for schema checking! Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: JSON-RPC: `injectonionmessage` API simplified and documented.
…message. Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: Plugins: new notification `onionmessage_forward_fail`. Signed-off-by: Rusty Russell <[email protected]>
Doing exactly what we expect to do: initiate a connection and then forward the message. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/onionmessage_forward_fail-notif
branch
from
84f15fd to
67db24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, it's the freeze. But this involved an API change and we're better off releasing with that. It's quite neat, too.