Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Actions trigger of tag push #7625

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

ShahanaFarooqui
Copy link
Collaborator

⚠️ IMPORTANT:

Feature freeze date for v24.08 is Aug 5th.

RC1 is scheduled on Aug 10th, RC2 on Aug 15, ...

The final release is on Aug 22nd.

Changelog-Fixed: Regex expression for github actions tags push trigger.

.github/workflows/pypi.yml Show resolved Hide resolved
@ShahanaFarooqui ShahanaFarooqui force-pushed the github-docker-testing branch 3 times, most recently from aec7f05 to b885871 Compare August 31, 2024 20:49
@ShahanaFarooqui ShahanaFarooqui linked an issue Sep 1, 2024 that may be closed by this pull request
Changelog-Fixed: Regex expression for github actions tags push trigger.
Changelog-Fixed: Core lightning's version will not be suffixed with -modded anymore.
Running `git describe` in local setup correctly identifies the tag available on the tag. But `docker buildx` via actions does not identify it without `--tags` param.

Reference Issue: #7626

Changelog-Fixed: Docker image created via github actions correctly reads the tag available on the HEAD.
@ShahanaFarooqui ShahanaFarooqui merged commit 1a71e15 into master Sep 5, 2024
38 checks passed
@ShahanaFarooqui ShahanaFarooqui deleted the github-docker-testing branch September 5, 2024 19:31
@ShahanaFarooqui ShahanaFarooqui added this to the v24.08.2 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiarch docker builds of pre-releases
2 participants