Rust-bins: Upgrade tonic to v0.12 for v0.1.8 #7597
Conversation
nepet
changed the title
ShahanaFarooqui
force-pushed
the
cln-rust-bins-v0.2-upgrade-tonic-version
branch
from
2140774 to
9a16a65
Compare
Tonic had some breaking changes since 0.8. We want to be closer to newer versions for downstream consumers to be able to benefit from changes in tonic. Signed-off-by: Peter Neuroth <[email protected]>
We bump the version to minor version 0.2 to allow ourselves to bump on patch level when we need to fix a bug or update a dependency. Changelog-Changed: Plugins: `cln-grpc` Upgrade tonic version and introduce new versioning scheme. Signed-off-by: Peter Neuroth <[email protected]>
ShahanaFarooqui
force-pushed
the
cln-rust-bins-v0.2-upgrade-tonic-version
branch
from
9a16a65 to
665fe1a
Compare
|
Thanks for rebasing @ShahanaFarooqui, but rebasing on The reason for this PR was to bump the version to a new minor version that allows us to upgrade dependencies (like However, it turned out that the reason for an "urgent" update of the Let's just bump the rust crates form |
|
Closed, moved to #7598 |
Upgrade tonic to
v0.12for rust binsv0.1.8Description
This PR upgrades the tonic dependency of the rust libraries to
v0.12. Latest version used wasv0.8. Tonic had some major bugfixes in between these versions. We need to upgrade tonic for downstream consumers of our libs to be able to upgrade tonic as well.This PR also introduces a new versioning scheme where we bump the minor semver version on any breaking api change such as the removal of deprecated calls as well as changes to the requirements of fields.
The whole rust lib stack
cln-grpccln-rpccln-pluginandcln-grpc-pluginis now onv0.2.x, on top of tag clnv24.02.2for the underlying message scheme.