-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub docker testing #7571
Merged
Merged
GitHub docker testing #7571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
from
August 14, 2024 03:54
b0d8ab0
to
b4ce524
Compare
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
24 times, most recently
from
August 19, 2024 23:59
ed04380
to
521fb6b
Compare
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
from
August 20, 2024 01:31
521fb6b
to
7a43c97
Compare
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
5 times, most recently
from
August 20, 2024 05:15
2892fd6
to
167e91e
Compare
ACK 167e91e Just a minor discrepancy between envvars and their documentation (push defaults to true, rather than false as the docs claim). |
cdecker
approved these changes
Aug 20, 2024
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
2 times, most recently
from
August 20, 2024 20:48
e610300
to
eec6993
Compare
- Temporarily adding `rc` tag trigger for testing `Build and push multi-platform docker images` action flow before the final release. - Added some variable inputs for testing like repo, platforms, etc. - Added more logs for future debugging.
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
from
August 20, 2024 21:10
eec6993
to
30d69b3
Compare
- **Poetry Issue:** The Docker build for `linux/arm/v7` failed in recent RC releases on the Poetry installation step in the `builder-python` stage. This issue occurred because the `builder-python` stage builds on target's arch but poetry was unable to install on arm/v7 without rust >= v1.56.1. - **Solution:** Instead of installing poetry on the `builder-python` stage, we leveraged the existing multi-arch `builder` stage, which already had Poetry. Now, we export the dependencies from `pyproject.toml` to `requirements.txt` within the `builder` stage and then copy `requirements.txt` to the `builder-python` stage for pip installation. - **Cryptography installation Issue:** python installations for `pyln-proto` started failing due to Cryptography upgrade from v41 to v42 (#7475). It is because now Cryptography needs cargo/rust also. - **Solution:** Installing cargo in `builder-python` stage also. - **Configure Prefix Issue:** Previously, we used `RUN ./configure --prefix=/tmp/lightning_install --enable-static` in the `builder` image and then copied `/tmp/lightning_install` from the `builder` stage to `/usr/local` in the `final` stage. However, this approach is now causing errors due to missing binaries/plugins at their default locations. - **Solution:** We are now configuring the installation to use the default location (`/usr/local`). To prevent the local image size from increasing by up to 87MB, instead of copying the entire `/usr/local/` directory, we are explicitly copying only the core lightning binaries. Changelog-Fixed: Fixes failing Docker build for `arm32` arch.
ShahanaFarooqui
force-pushed
the
github-docker-testing
branch
from
August 21, 2024 00:24
30d69b3
to
91d1c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily adding
rc
tag trigger, some input variables & more logs for testingBuild and push multi-platform docker images
action flow before the final release.Poetry on arm32: The Docker build for
linux/arm/v7
failed in recent RC releases on the Poetry installation step in thebuilder-python
stage. This issue occurred because thebuilder-python
stage builds on target's arch but poetry was unable to install on arm/v7 without rust >= v1.56.1.builder-python
stage, we leveraged the existing multi-archbuilder
stage, which already had Poetry. Now, we export the dependencies frompyproject.toml
torequirements.txt
within thebuilder
stage and then copyrequirements.txt
to thebuilder-python
stage for pip installation.Cryptography installation: python installations for
pyln-proto
started failing due to Cryptography upgrade from v41 to v42 (PR pyln-proto: update cryptography to v42 #7475). It is because now Cryptography needs cargo/rust also.builder-python
stage also.Configure Prefix: Previously, we used
RUN ./configure --prefix=/tmp/lightning_install --enable-static
in thebuilder
image and then copied/tmp/lightning_install
from thebuilder
stage to/usr/local
in thefinal
stage. However, this approach is now causing errors due to missing binaries/plugins at their default locations./usr/local
). To prevent the local image size from increasing by up to 87MB, instead of copying the entire/usr/local/
directory, we are explicitly copying only the core lightning binaries.Changelog-Fixed: Fixes failing Docker build for
arm32
arch.