Add categories in RPC documentation #7485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
force-pushed
the
doc-rpc-categories
branch
2 times, most recently
from
e2aa506 to
24e0707
Compare
ShahanaFarooqui
force-pushed
the
doc-rpc-categories
branch
3 times, most recently
from
20c04a6 to
19afa12
Compare
ShahanaFarooqui
force-pushed
the
doc-rpc-categories
branch
from
19afa12 to
5e8f690
Compare
ShahanaFarooqui
force-pushed
the
doc-rpc-categories
branch
from
5e8f690 to
72c4775
Compare
…m plugin_command struct Changelog-None.
ShahanaFarooqui
force-pushed
the
doc-rpc-categories
branch
from
72c4775 to
c8698fe
Compare
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Aug 3, 2024
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation ElementsProject#7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-None.
ShahanaFarooqui
added a commit
to ShahanaFarooqui/lightning
that referenced
this pull request
Aug 6, 2024
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation ElementsProject#7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.
rustyrussell
pushed a commit
that referenced
this pull request
Aug 7, 2024
…m method Category, description and long description from `json_command` and `plugin_command` have been removed in favour of getting them from json schema. Reference PR: Add categories in RPC documentation #7485 Deprecating them in pyln-client as well. They will remove completely in future releases. Changelog-Deprecated: pyln-client: category, description and long descriptions for RPC commands are deprecated now.
Lagrang3
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Too bad this breaks new plugins from running on older nodes. For example renepay compiled on the master branch after this PR a82f1fe, will not run on v24.05, because description will be missing from the getmanifest response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readonlycategory forget&listcommands exceptlistdatastorecategoryandverbosefrom json_command structuredescriptionfrom json_command structurecategory,descriptionandlong_descriptionfrom plugin_command structChangelog-None.