-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce support for alternative addresses for peer connections #7422
base: master
Are you sure you want to change the base?
Conversation
Thanks @maxrantil for the proposal. I read through the description, and I'm not sure I understand the rationale for this change. Is this intended as a way to say "hey, if we get disconnected, this is how you can reach me again", or is the intention something else? Just thought I'd ask this before looking at the code itself, wanting to start with the right mental model. |
Hi @cdecker , as you might know, this project is part of Summer of Bitcoin and this is the project description:
I think this answers your question, right? |
Oh, cool, yeah I hadn't made the connection right away. Thanks for sharing the description, it's much clearer now |
f6bacf0
to
24018af
Compare
d212cd9
to
572a616
Compare
821e28d
to
e461ad2
Compare
aae893b
to
e6ff7da
Compare
0360fcf
to
be019d1
Compare
- Aswell as parameters alt-bind-addr and alt-announce-addr Changelog-Added: Introduced the 'alt-addr' config parameter for specifying alternative addresses. Signed-off-by: Max Rantil <[email protected]>
be019d1
to
6be03fc
Compare
This PR introduces a new configuration parameter,
alt_addr
, which allows specifying an alternative address for peer connections.Key Features
alt_addr
is specified, this address is communicated to the peer.alt_addr
is used to establish the connection.alt-addr
,alt-bind-addr
, andalt-announce-addr
for managing alternative addresses.alt-bind-addr
for specific peers.