msggen: All the changes in one PR #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dropping #7257 from the bundle as it is running into an type-mixup issue. I'll let @daywalker90 rebase that one. |
cdecker
force-pushed
the
20240516-monster-msggen
branch
2 times, most recently
from
60af0f0 to
f8d88c7
Compare
|
Dropping #7266 from the bundle as well, since there is a missing |
cdecker
force-pushed
the
20240516-monster-msggen
branch
2 times, most recently
from
89b384e to
b8a6512
Compare
|
found one more: #7267, rest should be fine! |
|
Perfect, thanks @daywalker90, I am letting the current run finish and then I'll push the branch with #7257, #7266 and #7267 re-added. They look good now ^^ |
Changelog-None
Changelog-None
Changelog-None
Changelog-None
Changelog-None
…t methods Changelog-None
Changelog-None
cdecker
force-pushed
the
20240516-monster-msggen
branch
from
65f84ff to
07b8e28
Compare
Changelog-None
Changelog-None
Changelog-None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got really annoyed at the CI for its flakiness, and was not looking
forward to have to do it 20x just to get all these merged, so I'm
doing exactly what I told @daywalker90 not to do, and am bundling the
changes into one large cluster. This PR just subsumes all the ones
that I have reviewed and would be shepherding through CI anyway.
Closes #7264
Closes #7262
Closes #7263
Closes #7265
Closes #7257
Closes #7266
Closes #7267
Closes #7268
Closes #7270
Closes #7271
Closes #7275