Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/clnrest: Adding new config param as clnrest-swagger-root #7226

Merged

Conversation

ShahanaFarooqui
Copy link
Collaborator

@ShahanaFarooqui ShahanaFarooqui commented Apr 16, 2024

For BTCPay, the swaggerUI doesn't come up because it assume that it is running on the base of the domain. It will be easier to use, for BTCPay and others, if the SwaggerUI's root url can be configured.

  • Updated config params and plugin
  • Updated documentation

Changelog-Added: Added a new configuration for clnrest plugin to change the default Swagger UI path from / to custom url.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b98949

- Updated config params and plugin
- Updated documentation

Changelog-Added: Added a new configuration for clnrest plugin to change the default Swagger UI path from `/` to custom url.
@endothermicdev
Copy link
Collaborator

Looks good. Rebased to avoid merge conflict with wss proxy.

ACK f18b87a

@endothermicdev endothermicdev merged commit 95a92b6 into ElementsProject:master Apr 24, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants