Reckless: Avoid github API limits #7091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github API calls are now ratelimited to 60 per hour. Searching through the subdirectory contents of lightningd/plugins will hit this limit after two searches or installs. The simple answer is to look for the directory rather than verifying a valid entrypoint in a suitably-named directory prior to cloning the repository. Also corrects a bug that was flagging submodules as files while populating directory contents.
rustyrussell
approved these changes
Feb 20, 2024
Due to the API ratelimit, this allows cloning a github repo and searching the result rather than searching via the REST API. If a source has already been cloned, it is fetched and the default branch checked out. Fixes a failure reported by @farscapian Changelog-Fixed: Reckless no longer fails on github API ratelimit.
If it has already been cloned, this is less problematic than using the github rest API.
Git ls-tree does not report submodule contents which was not previously accounted for.
endothermicdev
force-pushed
the
reckless-github-api-limits
branch
from
4b6e5c4 to
f1dc749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitting the github REST API was becoming a problem (26 directories to search and a default limit of 60 github API calls per hour.) This PR drastically reduces REST API calls to search the lightningd/plugins repo. It also adds a fallback method of cloning the repo and searching locally. Then, if the repo had previously been cloned, it prefers to update and search that.