cln_plugin: switch lifetimes of ConfigOption from static to non-static #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ack 42f8368 |
|
ACK 42f8368 |
cdecker
force-pushed
the
configoption-lifetimefix
branch
from
42f8368 to
25241e2
Compare
cdecker
force-pushed
the
configoption-lifetimefix
branch
from
25241e2 to
704de95
Compare
|
Rebased on top of master, and merging as soon as CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static lifetimes are a bit "too long".
Since ConfigOption is
#[derive(Clone, Debug)]it made sense to also make all theconfig_typelike that.