Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect hex value for Signet port #7078

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jrakibi
Copy link
Contributor

@jrakibi jrakibi commented Feb 14, 2024

The comments in chainparams.h list Signet's port hex as 0xF87 which should be 0x9B77. This needs updating to match the actual port value

vincenzopalazzo

This comment was marked as off-topic.

@vincenzopalazzo vincenzopalazzo self-requested a review February 15, 2024 13:45
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving a small comment, and thanks to catch my mistake

@cdecker cdecker force-pushed the fix-signet-port-hex branch from be66829 to fad9336 Compare February 16, 2024 13:59
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cdecker cdecker enabled auto-merge (rebase) February 16, 2024 14:00
@cdecker cdecker merged commit 1fdc018 into ElementsProject:master Feb 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants