Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renepay bug fix: list previous sendpays #7076

Closed
wants to merge 0 commits into from

Conversation

Lagrang3
Copy link
Collaborator

@Lagrang3 Lagrang3 commented Feb 14, 2024

I tried renepay on mainnet. At first the command timed-out, hence I called it
again and then I've got

Strange error from sendpay: {"code":201,"message":"There already is a payment with payment_hash=..., groupid=2, partid=1. Either change the partid, or wait for the payment to complete and start a new group."}{
   "code": -4,
   "message": "Plugin terminated before replying to RPC call."
}

While investigating this problem I've found a couple of bugs on the function that processes the result of listsendpays and decides the new groupid and the start counter for partid. Also shadow fees were buggy.
This PR fixes those.

@Lagrang3 Lagrang3 added the bug label Feb 14, 2024
@Lagrang3 Lagrang3 changed the title renepay bug fix: list previous sendpays [WIP] renepay bug fix: list previous sendpays Feb 14, 2024
@Lagrang3 Lagrang3 force-pushed the renepay-fix-sendpay branch from 06b708e to 7054383 Compare February 14, 2024 15:22
@Lagrang3 Lagrang3 changed the title [WIP] renepay bug fix: list previous sendpays renepay bug fix: list previous sendpays Feb 14, 2024
@Lagrang3 Lagrang3 marked this pull request as ready for review February 14, 2024 15:22
@Lagrang3 Lagrang3 force-pushed the renepay-fix-sendpay branch 2 times, most recently from c5c6cbf to 4061369 Compare February 14, 2024 16:08
@rustyrussell rustyrussell added this to the v24.02 milestone Feb 15, 2024
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK for the C side, but I have a small comment on the python test

tests/test_renepay.py Outdated Show resolved Hide resolved
@cdecker cdecker closed this Feb 16, 2024
@cdecker cdecker force-pushed the renepay-fix-sendpay branch from ee210a2 to 4c5c53c Compare February 16, 2024 14:06
@cdecker
Copy link
Member

cdecker commented Feb 16, 2024

This PR was subsumed in your other PR, so this is closed for being empty :-)

@Lagrang3 Lagrang3 deleted the renepay-fix-sendpay branch February 17, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants