Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add documentation for dev-forget-channel #7041

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

bitkarrot
Copy link
Contributor

Hi,

First attempt at the docs for the above command. I did run make doc-all and the markdown was generated correctly, but not sure about the *.requests.json.

@ShahanaFarooqui

Issue reference:
#6923

@bitkarrot bitkarrot marked this pull request as ready for review February 6, 2024 06:18
@bitkarrot
Copy link
Contributor Author

@ShahanaFarooqui I am failing to rebase this and I have run out of battery ( power outage here for next 24 hrs).

Apologies if i messed up the branch in my attempts to rebase and fix the merges

@cdecker cdecker marked this pull request as draft February 6, 2024 12:23
@ShahanaFarooqui ShahanaFarooqui self-requested a review February 6, 2024 17:40
@ShahanaFarooqui ShahanaFarooqui added this to the v24.05 milestone Feb 6, 2024
@ShahanaFarooqui ShahanaFarooqui linked an issue Feb 12, 2024 that may be closed by this pull request
4 tasks
@ShahanaFarooqui
Copy link
Collaborator

@bitkarrot, Thank you for the PR, I will re-base and review this PR once the PR #6995 is merged.

@ShahanaFarooqui ShahanaFarooqui force-pushed the main branch 3 times, most recently from 1d54aaf to fe6b0a9 Compare March 19, 2024 20:58
@ShahanaFarooqui
Copy link
Collaborator

ShahanaFarooqui commented Mar 19, 2024

@bitkarrot I re-based the PR on master and cleaned up multiple #empty doc/makefile update commits.

There were some more updates required after PR #6995 merge:

  • Merged request and schema jsons into single lightning-dev-forget-channel.json
  • Deleted lightning-dev-forget-channel.7.md file because it is fully generated by the script now.

I did change below details in the json schema too:

  • Edited required array according to the command
  • Types and description of request and response params
  • Added errors list returned by the command

Please check and let me know if you need more explanation.

@ShahanaFarooqui ShahanaFarooqui marked this pull request as ready for review March 19, 2024 21:10
@ShahanaFarooqui ShahanaFarooqui merged commit e331532 into ElementsProject:master Mar 22, 2024
35 checks passed
@bitkarrot
Copy link
Contributor Author

Thanks @ShahanaFarooqui !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for dev-forget-channel command too
2 participants