Enhance plugin_log_handle to accommodate multi-line messages #7013
Conversation
|
I'm not convinced that this is actually what we want, as it breaks a very basic assumption we make when logging: one log line == one event. This patch spreads a single log ling across many lines, potentially interleaving them, and breaking the event apart. It also breaks the assumption that each line starts with the preamble consisting of datetime and level. This means it is not filterable as nicely after the fact. |
|
@cdecker WDYT of that adjustment? Or should we just close out the issue instead? |
|
Yes, you cannot allow \n inside logs. However, you can split one level higher and turn them into multiple log messages, for sure! |
|
Converted to a draft. |
|
@rustyrussell Thanks for clarifying this! I'm working on this. Please expect an update in next few days! |
There are only 3 options, not 4, in the list.
Previously, the code utilized JSON-encoded text to pass log messages to the log_() function, resulting in new lines being printed to the log as '\n'. This commit addresses this issue by unescaping and splitting the log message into lines, with each non-empty line being logged separately. It is deemed acceptable to pass non-printable characters to log_() since they are replaced with "?" in the logv() function, invoked by log_(). Therefore, leaving lines JSON unescaped is permissible. It's important to note that only the last log_() call may have call_notifier set to true. This adjustment is crucial to prevent Python tracebacks complaining about a broken pipe after lightningd exits. Fix ElementsProject#4912 For reference, the log of lightningd failing without a backend: ./lightningd/lightningd 2024-02-08T20:33:17.642Z INFO lightningd: v23.11-257-g968d6d6-modded Could not connect to bitcoind using bitcoin-cli. Is bitcoind running? Make sure you have bitcoind running and that bitcoin-cli is able to connect to bitcoind. You can verify that your Bitcoin Core installation is ready for use by running: $ bitcoin-cli echo 'hello world' 2024-02-08T20:33:18.227Z **BROKEN** plugin-bcli: Could not connect to bitcoind using bitcoin-cli. Is bitcoind running? 2024-02-08T20:33:18.227Z **BROKEN** plugin-bcli: Make sure you have bitcoind running and that bitcoin-cli is able to connect to bitcoind. 2024-02-08T20:33:18.227Z **BROKEN** plugin-bcli: You can verify that your Bitcoin Core installation is ready for use by running: 2024-02-08T20:33:18.227Z **BROKEN** plugin-bcli: $ bitcoin-cli echo 'hello world' 2024-02-08T20:33:18.227Z INFO plugin-bcli: Killing plugin: exited before we sent init The Bitcoin backend died.
starius
force-pushed
the
issue-4912
branch
2 times, most recently
from
0f5ec37 to
7debaf3
Compare
starius
changed the title
|
I changed the approach: I split the message in plugin_log_handle function to several lines and log them independently. Please take another look! |
Previously, the code utilized JSON-encoded text to pass log messages to the log_() function, resulting in new lines being printed to the log as '\n'. This commit addresses this issue by unescaping and splitting the log message into lines, with each non-empty line being logged separately.
It is deemed acceptable to pass non-printable characters to log_() since they are replaced with "?" in the logv() function, invoked by log_(). Therefore, leaving lines JSON unescaped is permissible.
It's important to note that only the last log_() call may have call_notifier set to true. This adjustment is crucial to prevent Python tracebacks complaining about a broken pipe after lightningd exits.
Fixes: #4912
Tested: