regtest: error message if bitcoin-cli is not found #6966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
ACK 557a135
Appy to see that someone is really using this :)
|
ACK 557a135 Thanks!! |
If $BITCOIN_BIN is empty and bitcoin-cli or bitcoind are not found startup_regtest will shutdown and display a corresponding error message. Similarly if lightning-cli and lightningd are not found.
cdecker
force-pushed
the
regtest-bitcoin-not-found
branch
from
557a135 to
1d91208
Compare
|
ACK 1d91208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
$BITCOIN_BINis empty andbitcoin-cliorbitcoindare not foundstartup_regtestwill shutdown and display a corresponding error message.Similarly if
lightning-cliandlightningdare not found.Before this, the script would simply stop execution without any message whatsoever.