Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG.md: Update for 23.11rc2 #6875

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

nepet
Copy link
Collaborator

@nepet nepet commented Nov 16, 2023

Update changelog and py versions for second release candidate that includes mainly some tests for cln-rest

@nepet nepet requested a review from cdecker as a code owner November 16, 2023 14:36
@nepet nepet changed the title CHANGELOG.md: Update for 23.11rc1 CHANGELOG.md: Update for 23.11rc2 Nov 16, 2023
@nepet nepet force-pushed the release-23.11-rc2 branch from 92a3d8c to 6521447 Compare November 16, 2023 14:52
@endothermicdev
Copy link
Collaborator

the changed section should include the cln prefix added to clnrest config options. The full changes are:

config option `rest-certs` changed to `clnrest-certs`
config option `rest-protocol` changed to `clnrest-protocol`
config option `rest-host` changed to `clnrest-host`
config option `rest-port` changed to `clnrest-port`
config option `rest-cors-origins` changed to `clnrest-cors-origins`
config option `rest-csp` changed to `clnrest-csp`

Could probably be summarized in a single line as
clnrest config options rest-certs, rest-protocol, rest-host, rest-port, rest-cors-origins, rest-csp are all now prefixed with cln in order to avoid clashing with c-lightning-REST. (i.e., rest-port to clnrest-port) ([#6857])

@endothermicdev
Copy link
Collaborator

Is incrementing the pyln versioning necessary for rc2? I might prefer leaving them as 23.11 for simplicity.

@nepet
Copy link
Collaborator Author

nepet commented Nov 16, 2023

Thanks for your feedback @endothermicdev. I'll work it in and let you know once I am done!

@nepet nepet force-pushed the release-23.11-rc2 branch from 6521447 to b1fd12c Compare November 16, 2023 16:00
CHANGELOG.md Outdated Show resolved Hide resolved
@nepet nepet force-pushed the release-23.11-rc2 branch from b1fd12c to 749b694 Compare November 16, 2023 18:25
@endothermicdev
Copy link
Collaborator

ACK 749b694

@nepet nepet force-pushed the release-23.11-rc2 branch from 749b694 to cdb54a5 Compare November 17, 2023 09:59
@nepet
Copy link
Collaborator Author

nepet commented Nov 17, 2023

Added #6876

@nepet nepet force-pushed the release-23.11-rc2 branch from cdb54a5 to abbceb5 Compare November 20, 2023 06:43
@nepet
Copy link
Collaborator Author

nepet commented Nov 20, 2023

Added #6840 to the release candidate.

@nepet nepet enabled auto-merge (rebase) November 20, 2023 06:43
@nepet nepet merged commit 8aff6f7 into ElementsProject:master Nov 20, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants