Update pyln-testing cheroot dependency #6845
Conversation
|
Might need poetry update or something? But a good idea! |
Using `pyln-testing` with `python3.11` results in the following warning. ``` .../venv/lib/python3.11/site-packages/cheroot/__init__.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html import pkg_resources ``` I've updated the `cheroot`-dependency. However, the changes will not take effect immediately because we are facing an internal conflict. This conflict comes from the following requirements - `//contrib/pyln-testing/pyproject.toml` requires `cheroot`. We can pick the requried version - `./external/lnprototest/pyproject.toml` requires `pyln="^0.12"` requires `cheroot="^8" It appears we have to do a multi-stage upgrade here. **Step 1** This commit configures `./contrib/pyln-testing/pyproject.toml` to require `cheroot=">=8 <=10`. This allows users of `pyln-testing` to start using a new release of `cheroot` immediately. However, we still require `cheroot="^8"` because of `lnprototests`. Even after running `poetry install` in the project root the warning will remain. **Step 2** Not a part of this commit. Publish a new release of `pyln-testing` on PyPI. Once this release is finished we can update `./external/lnprototests/pyproject.toml` to use the new version of `pyln-testing` and the warning will disappear.
ErikDeSmedt
force-pushed
the
pyln-testing-update-deps
branch
from
b1472c9 to
179dfa1
Compare
|
Had to go down a little rabbit-hole. There is a conflict from the following requirements
It appears we have to do a multi-stage upgrade here. Step 1 However, we still require Step 2 Publish a new release of Once this release is finished we can update |
pyln-testing depends on cheroot~=8 which depends on pkg_resources.
In python3.11 this has been deprecated which results in the following warning