fuzz: bolt12 decoding #6820
Merged
fuzz: bolt12 decoding #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
Oct 30, 2023
common/bolt12.c
Outdated
Comment on lines
110
to
113
| STATIC_UNLESS_FUZZING const u8 *string_to_data(const tal_t *ctx, | ||
| const char *str, size_t str_len, | ||
| const char *hrp_expected, | ||
| size_t *dlen, char **fail) |
There was a problem hiding this comment.
I really dislike this level of intrusiveness; we go to great lengths to avoid this in unit tests, we should do the same for fuzz tests.
In particular, fuzzing should not be afraid to include raw C files to get this kind of access. It may mean you need to use generated mocks, like unit tests do, though?
Add fuzz targets for decoding of offers, invoice requests, and invoices. Mutators are shared in bolt12.h.
morehouse
force-pushed
the
fuzz_bolt12
branch
from
3bc2c8a to
4a14e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzz targets for decoding of bolt12 offers, invoice requests, and invoices. Based on the existing target for bolt11.