Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splice: Update test for new logs #6815

Merged

Conversation

ddustin
Copy link
Collaborator

@ddustin ddustin commented Oct 25, 2023

The log messages were changed but the test fields weren’t updated, resulting in some test flakiness. Being more explicit with the log message we’re looking for should help.

Fixes #6803

@ddustin ddustin added the flake Known CI flakes label Oct 25, 2023
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this diff is changing anything?

tests/test_splicing.py Outdated Show resolved Hide resolved
The log messages were changed but the test fields weren’t updated, resulting in some test flakiness. Being more explicit with the log message we’re looking for should help.

Changelog-None
@ddustin ddustin force-pushed the ddustin/splice_test_logfix branch from b979c6c to 5fd246d Compare October 26, 2023 15:30
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5fd246d

@rustyrussell rustyrussell merged commit 990f4d0 into ElementsProject:master Oct 27, 2023
31 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake Known CI flakes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

splice: bad commitment signature
3 participants