Closingd invalid fix #6787
Merged
Closingd invalid fix #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Sending closingd an invalid message 03f40000006d ... 0x564b55bb7378 fatal lightningd/log.c:1035 0x564b55bf7841 subd_send_msg lightningd/subd.c:841 0x564b55b87d08 try_update_blockheight lightningd/channel_control.c:143 0x564b55b8c497 channel_notify_new_block lightningd/channel_control.c:1687 0x564b55bb26bb notify_new_block lightningd/lightningd.c:743 ``` Signed-off-by: Rusty Russell <[email protected]>
Move the "no lease, return" to the top, to avoid testing twice. Also, we won't spam now for most channels. Signed-off-by: Rusty Russell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-None: introduced since release