Only 3 question marks for 4 variables #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hMsats Rather than merging master into your fork, first rebase your master on elementsproject's master then add your change in a single commit please. |
|
@ShahanaFarooqui better? 😃 |
ddustin
approved these changes
Sep 22, 2023
|
Yes. This means this code has never been run. |
vincenzopalazzo
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
ACK 465f173
It is sad to see that it was not caught by the review process. Sorry about that
ddustin
added a commit
to ddustin/lightning
that referenced
this pull request
Oct 5, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
ddustin
added a commit
to ddustin/lightning
that referenced
this pull request
Oct 5, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
ddustin
added a commit
to ddustin/lightning
that referenced
this pull request
Oct 14, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
rustyrussell
pushed a commit
to ddustin/lightning
that referenced
this pull request
Oct 23, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
rustyrussell
pushed a commit
to ddustin/lightning
that referenced
this pull request
Oct 23, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
rustyrussell
pushed a commit
to ddustin/lightning
that referenced
this pull request
Oct 23, 2023
* Regression test added for Issue ElementsProject#6572 (issuecomment-1730808863) w/stuck HTLC * `check_balance` adjusted to calculate pending HTLCs explicitly * Test confirmed to fail prior to PR ElementsProject#6713 ChangeLog-Fixed: Issue splicing with pending / stuck HTLCs fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this gave me a lot of problems while testing splicing. Don't ask me how I found it :-)