Begin weaning code off assumption that unannounced channels are in gossip store #6697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
rustyrussell
force-pushed
the
guilt/listchannels-gossip-only
branch
from
061da57 to
27a3a50
Compare
There was a problem hiding this comment.
looks like that this is vreaking some C test?
643.3 ld connectd/test/run-netaddress
643.4 ld connectd/test/run-responder-success
643.4 ld connectd/test/run-websocket
643.4 ld wallet/test/run-db
643.4 ld wallet/test/run-psbt_fixup
wallet/test/run-wallet.o: in function `wallet_rune_update_last_used':
643.7 /repo/./wallet/wallet.c:5765: undefined reference to `rune_unique_id'
643.7 collect2: error: ld returned 1 exit status
643.7 make: *** [Makefile:664: wallet/test/run-wallet] Error 1
643.7 rm external/build-x86_64-alpine-linux-musl/libwally-core-build/src/secp256k1/libsecp256k1.la
This breaks Dijkstra, which is presumably why it was actually disabled. Remove the code altoghether, instead. Changelog-Fixed: JSON-RPC: `getroute` now documents that it ignores `fuzzpercent`. Signed-off-by: Rusty Russell <[email protected]>
Mechanical change to bundle into struct getroute_info for next patch which uses callback. Signed-off-by: Rusty Russell <[email protected]>
This prepares us for when the gossmap doesn't contain private channel info. Signed-off-by: Rusty Russell <[email protected]>
The tests will wait until it's locally enabled, but it might not have the update in the gossip store. So have renepay enhance its local view even if it already knows about the channel (this is correct anyway, it just isn't very important usually). Signed-off-by: Rusty Russell <[email protected]>
We no longer support legacy at all, so this test doesn't really test anything. Signed-off-by: Rusty Russell <[email protected]>
…ivate channels. We will be changing this, or at least deprecating it, so get our tests ready. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/listchannels-gossip-only
branch
from
27a3a50 to
384106e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incomplete, but should make changing this easier. We will probably have to change listchannels (at least in deprecated mode!) to add local channels, but we can do that at the end.
This series is really a precursor for @endothermicdev to rebase onto.