Allow even unknown messages, by registration, and allow sending them #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
changed the title
rustyrussell
force-pushed
the
guilt/allow-even-messages
branch
from
41966f0 to
bb7f9a0
Compare
|
Looks good technically, though it needs a rebase. I know "It's your funeral," but maybe we should log a single message the first time the node sends a custom even message. That way there's at least a hint for the operator to grep for? |
| types, since that may cause issues with the internal state tracking of | ||
| Core Lightning. | ||
| Core Lightning. We do (as of *v23.11*) allow sending of even types, but note that peers (as per the spec) will disconnect on receiving unknown even types. |
There was a problem hiding this comment.
inconsistent line breaks
Good advice! Made the first one INFO, the DEBUG level after that. |
rustyrussell
force-pushed
the
guilt/allow-even-messages
branch
from
bb7f9a0 to
8dedd24
Compare
|
Rebased, and added log message. |
rustyrussell
force-pushed
the
guilt/allow-even-messages
branch
2 times, most recently
from
37f6d15 to
4d57992
Compare
|
Fixed sanitizer complaint about memcpy NULL, and rebased onto #6802 for flake fixes. |
Changelog-Added: Plugins: plugins can now specify (unknown) even messages we should accept from peers. Signed-off-by: Rusty Russell <[email protected]>
We re-send whenever a plugin which allows them starts/finishes. Signed-off-by: Rusty Russell <[email protected]>
It's your funeral! Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/allow-even-messages
branch
from
4d57992 to
f291af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4963 (ancient)
Closes: #4960