Dockerfile: Remove deprecated GMP dependency #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
approved these changes
Sep 16, 2023
There was a problem hiding this comment.
Checked with amd64 and amr64v8, both are building successfully.
ACK b935f88
this commit is not required anymore as we are using buildx for building both the images. I am about to delete Dockerfile.arm64v8 anyways. |
|
OK - Should I remove the |
It is fine to leave it as is for now. I will delete it in future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated GMP dependency since libsecp256k1 provides all the necessary functionality.
Enjoy faster build!