[CHORE] contrib/pyln-proto update bitstring #6585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests are not passing? |
|
i just ran tests inside |
|
i think i need some guidance. the purpose was just to bump bitstring :). |
dni
force-pushed
the
pylnproto-update-deps
branch
from
2b3d7dd to
0b6345a
Compare
dni
force-pushed
the
pylnproto-update-deps
branch
from
0b6345a to
113f91e
Compare
There was a problem hiding this comment.
if you cherrypick the commit at #6590 this should fix the Ci and be ready to merge the PR
dni
force-pushed
the
pylnproto-update-deps
branch
from
113f91e to
eb55dca
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
update to latest bitstring, `type: ignore` is not needed anymore forgot poetry.lock run makegen run make -j8 remove cln-renepay mako capitalized?
dni
force-pushed
the
pylnproto-update-deps
branch
from
37c023d to
0388bf3
Compare
|
Ok looks liek that in the CI something is broken with the docket compose, there is the following error try to apply this patch diff --git a/contrib/docker/scripts/build.sh b/contrib/docker/scripts/build.sh
index c9cb48228..3692dcd3b 100755
--- a/contrib/docker/scripts/build.sh
+++ b/contrib/docker/scripts/build.sh
@@ -23,7 +23,7 @@ export LIGHTNINGD_POSTGRES_NO_VACUUM=1
pip3 install --upgrade pip
pip3 install --user poetry
poetry export --dev --without-hashes -o requirements.txt
-pip3 install -r requirements.txt
+pip3 install --ignore-installed -r requirements.txt
pip3 install -r plugins/clnrest/requirements.txt
git clone https://github.com/lightning/bolts.git ../bolts
|
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Aug 24, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Aug 24, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Aug 24, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Aug 24, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
|
OK while fightling with poetry a little bit I think this patch #6607 will introduce the feature that you need. Waiting of the CI completion |
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Aug 29, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
nepet
pushed a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Oct 23, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] ElementsProject#6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
rustyrussell
pushed a commit
that referenced
this pull request
Oct 24, 2023
This is an alternative version to [1] that update only the necessary information around our codebase to upgrade the bitstring package. This upgrade is necessary for the user of our package that will find conflics in their codebase about packages version. [1] #6585 Co-Developed-by: @dni Chanegelog-None Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to latest bitstring,
type: ignoreis not needed anymore.tests are passing