Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splice: Agressive restart testing during splices #6569

Merged

Conversation

ddustin
Copy link
Collaborator

@ddustin ddustin commented Aug 15, 2023

Test node restarts in lots of phases of splice.

Changelog-None

@ddustin ddustin force-pushed the ddustin/test_splice_restart branch 6 times, most recently from 7b7047f to 87b639f Compare August 16, 2023 02:40
@rustyrussell rustyrussell added this to the v23.08 milestone Aug 16, 2023
@ddustin ddustin force-pushed the ddustin/test_splice_restart branch 6 times, most recently from 8fad525 to 21be6e7 Compare August 16, 2023 21:40
@rustyrussell
Copy link
Contributor

Oh, splicing go boom! In particular, we have reproduced #6572

@ddustin ddustin marked this pull request as draft August 17, 2023 13:05
@ddustin ddustin force-pushed the ddustin/test_splice_restart branch from 21be6e7 to 4486ba2 Compare August 17, 2023 13:07
@ddustin ddustin removed this from the v23.08 milestone Aug 23, 2023
@ddustin ddustin force-pushed the ddustin/test_splice_restart branch from 4486ba2 to 77749bf Compare November 7, 2023 17:38
@ddustin ddustin marked this pull request as ready for review November 7, 2023 17:38
@ddustin ddustin force-pushed the ddustin/test_splice_restart branch 7 times, most recently from b8b01b9 to 60a0c1b Compare November 9, 2023 00:42
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand the goal of this PR

Looks like that this PR is dependent from #6840 right? So maybe after the merge this start to be more cleaner?

Test node restarts in lots of phases of splice.

Changelog-None
@ddustin ddustin force-pushed the ddustin/test_splice_restart branch from 60a0c1b to bc1cce8 Compare December 13, 2023 20:23
@ddustin ddustin added this to the v24.02 milestone Dec 14, 2023
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack bc1cce8

@rustyrussell rustyrussell merged commit 6f4a3c8 into ElementsProject:master Dec 14, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants