Skip to content

Commit

Permalink
schemas: "description" field in "wait(any)invoice" is optional since …
Browse files Browse the repository at this point in the history
…BOLT12

For BOLT12 invoices, the "description" is field missing in the invoice
responses. Update the schemas accordingly:

- `doc/schemas/lightning-waitanyinvoice.json`
- `doc/schemas/lightning-waitinvoice.json`

Also commit the generated msggen, cln-grpc, cln-rpc and pyln-grpc-proto files.

Changelog-Fixed: schemas: Make description in `Wait(any)invoiceResponse` optional to handle BOLT12
  • Loading branch information
laanwj authored and rustyrussell committed Sep 16, 2024
1 parent 5bd3d51 commit c8660c8
Show file tree
Hide file tree
Showing 7 changed files with 712 additions and 714 deletions.
4 changes: 2 additions & 2 deletions cln-grpc/proto/node.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions cln-grpc/src/convert.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions cln-rpc/src/model.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions contrib/msggen/msggen/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -33516,7 +33516,6 @@
"response": {
"required": [
"label",
"description",
"payment_hash",
"status",
"created_index",
Expand Down Expand Up @@ -33877,7 +33876,6 @@
"response": {
"required": [
"label",
"description",
"payment_hash",
"status",
"created_index",
Expand Down
1,408 changes: 704 additions & 704 deletions contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion doc/schemas/lightning-waitanyinvoice.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"response": {
"required": [
"label",
"description",
"payment_hash",
"status",
"created_index",
Expand Down
1 change: 0 additions & 1 deletion doc/schemas/lightning-waitinvoice.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"response": {
"required": [
"label",
"description",
"payment_hash",
"status",
"created_index",
Expand Down

0 comments on commit c8660c8

Please sign in to comment.