Skip to content

Commit

Permalink
ci: Fetch tags while building so the binaries know
Browse files Browse the repository at this point in the history
We weren't compiling with tags, causing the version command to just
return the git commit hash, rather than a valid version string.
  • Loading branch information
cdecker committed Feb 21, 2024
1 parent 18328fc commit c1f52cb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0
fetch-tags: true

- name: Rebase
# We can't rebase if we're on master already.
Expand Down Expand Up @@ -94,6 +95,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0
fetch-tags: true

- name: Set up Python 3.8
uses: actions/setup-python@v4
Expand Down

0 comments on commit c1f52cb

Please sign in to comment.