Skip to content

Commit

Permalink
libhsmd: removing assertion on push_value
Browse files Browse the repository at this point in the history
The assertion may not make sense if we change the
meaning of `push_value` to be relative, especially since
negative values appear as large positive.

Suggested-by: Ken Sedgwick <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
  • Loading branch information
vincenzopalazzo authored and rustyrussell committed Oct 23, 2023
1 parent 4649bcc commit a6e1f19
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion hsmd/libhsmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,6 @@ static u8 *handle_setup_channel(struct hsmd_client *c, const u8 *msg_in)
/* Fail fast if any values are uninitialized or obviously wrong. */
assert(amount_sat_greater(channel_value, AMOUNT_SAT(0)));
assert(amount_sat_to_msat(&value_msat, channel_value));
assert(amount_msat_less_eq(push_value, value_msat));
assert(!mem_is_zero(&funding_txid, sizeof(funding_txid)));
assert(local_to_self_delay > 0);
assert(remote_to_self_delay > 0);
Expand Down

0 comments on commit a6e1f19

Please sign in to comment.