Skip to content

Commit

Permalink
gossipd: drive-by correction of new channel announcement evaluation
Browse files Browse the repository at this point in the history
According to the description, we should be checking the existence of a
channel update on the other side here.

Changelog-None
  • Loading branch information
endothermicdev authored and rustyrussell committed Nov 1, 2024
1 parent b327bd3 commit 80d666b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions gossipd/gossmap_manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 *

pca = map_del(&gm->pending_ann_map, scid);
if (!pca) {
/* If we looking specifically for this, we no longer
/* If we were looking specifically for this, we no longer
* are (but don't penalize sender: we don't know if it was
* good or bad). */
remove_unknown_scid(gm->daemon->seeker, &scid, true);
Expand Down Expand Up @@ -703,7 +703,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 *
txout_failures_add(gm->txf, scid);
out:
tal_free(pca);
/* If we looking specifically for this, we no longer are. */
/* If we were looking specifically for this, we no longer are. */
remove_unknown_scid(gm->daemon->seeker, &scid, false);
}

Expand Down Expand Up @@ -773,7 +773,7 @@ static const char *process_channel_update(const tal_t *ctx,
} else {
/* Is this the first update in either direction? If so,
* rewrite channel_announcement so timestamp is correct. */
if (!gossmap_chan_set(chan, dir))
if (!gossmap_chan_set(chan, !dir))
gossip_store_set_timestamp(gm->daemon->gs, chan->cann_off, timestamp);
}

Expand Down

0 comments on commit 80d666b

Please sign in to comment.