Skip to content

Commit

Permalink
docker: Add missing git dependency for Fedora Dockerfile
Browse files Browse the repository at this point in the history
Fedora image building by build-release.sh currently throws error ` git: command not found`.

Fixed it by adding git in the Dockerfile and loading the image in the script.

Changelog-None.
  • Loading branch information
ShahanaFarooqui authored and endothermicdev committed May 24, 2024
1 parent 0a163c4 commit 7f5282a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions contrib/docker/Dockerfile.builder.fedora
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ RUN dnf update -y && \
net-tools \
valgrind \
wget \
git \
jq \
xz \
zlib-devel && \
Expand Down
2 changes: 1 addition & 1 deletion tools/build-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ for target in $TARGETS; do
echo "Building Fedora Image"
DOCKERFILE=contrib/docker/Dockerfile.builder.fedora
TAG=fedora
docker build -f $DOCKERFILE -t $TAG .
docker build -f $DOCKERFILE -t $TAG --load .
docker run --rm=true -v "$(pwd)":/src:ro -v "$RELEASEDIR":/release $TAG /src/tools/build-release.sh --inside-docker "$VERSION" "$platform"
docker run --rm=true -w /build $TAG rm -rf /"$VERSION-$platform" /build
echo "Fedora Image Built"
Expand Down

0 comments on commit 7f5282a

Please sign in to comment.