Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bip39: expose a non-allocating bip39_get_word_by_index #428

Merged
merged 1 commit into from
Oct 29, 2023
Merged

bip39: expose a non-allocating bip39_get_word_by_index #428

merged 1 commit into from
Oct 29, 2023

Conversation

jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented Oct 27, 2023 •
edited
Loading

Fixes #427

@jgriffiths jgriffiths mentioned this pull request Oct 27, 2023
Closed
benma
benma approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

include/wally_bip39.h Show resolved Hide resolved
@jgriffiths jgriffiths merged commit d663a77 into master Oct 29, 2023
4 checks passed
@jgriffiths jgriffiths deleted the const_get_word branch October 29, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benma benma benma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

why does bip39_get_word() use the heap -- can we have a function that returns a const char* instead?
2 participants
@jgriffiths @benma