Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further ABI updates #422

Closed
wants to merge 2 commits into from
Closed

Further ABI updates #422

wants to merge 2 commits into from

Conversation

jgriffiths
Copy link
Contributor

Expose alloc functions and set the DSO version.

jgriffiths and others added 2 commits October 3, 2023 18:17
Third party libraries that make use of wally can use these calls to
avoid potential mismatches by end user applications that override the
default allocator.
version-info is what determines the dotted triplet of numbers trailing
the shared library filename. Meticulous maintenance of version-info
allows multiple ABI versions of the library to be installed on a system
concurrently and also makes obvious when library clients need to be
recompiled for a newer ABI (and when no recompilation is necessary).

See: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
@whitslack
Copy link
Contributor

@jgriffiths: LT_VER_CURRENT needs to start at 1 because you've already burned the .0 soname in prior releases.

@jgriffiths
Copy link
Contributor Author

@jgriffiths: LT_VER_CURRENT needs to start at 1 because you've already burned the .0 soname in prior releases.

Yes, I will bump it to 1 with the release of 1.0, prior to that being tagged all bets remain off!

@whitslack
Copy link
Contributor

Yes, I will bump it to 1 with the release of 1.0, prior to that being tagged all bets remain off!

Agreed. I thought you were going to merge this PR to produce the 1.0 release. I've stripped out my fixup.

@jgriffiths
Copy link
Contributor Author

Merged under #423, closing.

@jgriffiths jgriffiths closed this Oct 30, 2023
@jgriffiths jgriffiths deleted the abi_merge branch October 30, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants