Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the bitcoin installation instructions #156

Conversation

ErikDeSmedt
Copy link

It turns out that bitcoin-core stopped maintaining the ppa.
I have updated the instructions to download form BitcoinCore instead.

This is also mentioned in issue 143.

It turns out that bitcoin-core stopped maintaining the ppa.
I have updated the instructions to download form BitcoinCore instead.
@wintercooled
Copy link
Collaborator

Nice one. I will review this now. Thanks.

@wintercooled
Copy link
Collaborator

wintercooled commented Apr 19, 2022

Make sure you'll download the binaries
Can you change this to "Make sure you download the binaries"

SHA256SUM.asc-file.
Can you change this to SHA256SUM.asc file.

The instances of SHA256SUM should I think be SHA256SUMS

/usr/bin/bitcoind
Should this not be /usr/local/bin/bitcoind ?

Thanks.

As commented by mathew
- you should download the SHA256SUMS-file (extra s)
- bitcoind should be in /usr/bin/local/bitcoind
@ErikDeSmedt
Copy link
Author

Your comments are on point.
I have updated them in the previous commit/

@wintercooled
Copy link
Collaborator

wintercooled commented Apr 19, 2022

Sorry - could you change the minor nits mentioned:

"Make sure you'll download the binaries"

  • Can you change this to "Make sure you download the binaries"

"SHA256SUM.asc-file."

  • Can you change this to "SHA256SUMS.asc file" (remove the -).

Then I will merge

Change phrasing of download instructions
@wintercooled
Copy link
Collaborator

wintercooled commented Apr 19, 2022

I think also a link to https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/trusted-keys is worth adding - as otherwise the key for checksums might be questioned. So you could make the "bitcoin-core maintainer" text a link to the above url perhaps?

@ErikDeSmedt
Copy link
Author

I have added a short explanation + link to the trusted keys

@wtogami
Copy link

wtogami commented Jul 2, 2022

I recommend exporting those keys as ascii armored text and including them in a folder in this repo.

@wintercooled wintercooled merged commit 2ca5e0b into ElementsProject:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants