-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add merge-prs.sh
script to contrib/
#923
base: master
Are you sure you want to change the base?
Conversation
Another thing we should deal with is that the functional tests sometimes fail due to resource contention (typically this looks like errors of the form |
I realize that the RPC errors only happen when I mess with my network interfaces while the tests are running. Probably I should just not do that. |
More missing features
|
@gwillen do you remember what the point of all this "copy to |
Because otherwise, when the script starts checking out branches / merging things / etc., it is liable to check itself out of existence, if you are running it from inside the same repo it's operating on. (Or check itself out to the wrong version, or...) |
It won't check itself out of existence, because it only checks things out via It may update itself, yes, but this is probably expected and good. We could add some code that would detect changes (much easier to do than But regardless I think this will be very rare. |
TODO
chronic
and any other tools we might need