-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation testing and dependencies. #422
Conversation
Remove version restriction on docutil and add Sphinx dependencies. Fixes #371.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
It's just a suggestion, but if you are willing to make some changes, I think mkdocs (material theme) is widely used and much more intuitive than Sphinx, using markdown as the main format. Using easier setup also means there will be more contributions. I'm happy to help if you are willing to at least try it out! |
That's an interesting suggestion. I'll create an issue and we can figure it out there. Thanks! |
@kiyoon How do I catch the
but it didn't catch the ones flagged in the build/test. |
Never mind: |
I didn't fix all of the lint errors yet, and they still need to be addressed. In fact, there are some errors I don't like as much, and it really depends on the project so we should discuss which to ignore further. But you can treat most errors more like a development guide, not something that must pass. Switching on the diagnostics help you write cleaner code in general. The The If you set |
Fixing isort error is something like |
Yes, some of the errors seem overly pedantic and we should discuss. Thanks! |
Fixes #371