Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation testing and dependencies. #422

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

sobolevnrm
Copy link
Member

Fixes #371

Remove version restriction on docutil and add Sphinx dependencies.

Fixes #371.
@sobolevnrm sobolevnrm requested a review from Copilot December 30, 2024 03:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@kiyoon
Copy link
Collaborator

kiyoon commented Dec 30, 2024

It's just a suggestion, but if you are willing to make some changes, I think mkdocs (material theme) is widely used and much more intuitive than Sphinx, using markdown as the main format. Using easier setup also means there will be more contributions. I'm happy to help if you are willing to at least try it out!

@sobolevnrm
Copy link
Member Author

It's just a suggestion, but if you are willing to make some changes, I think mkdocs (material theme) is widely used and much more intuitive than Sphinx, using markdown as the main format. Using easier setup also means there will be more contributions. I'm happy to help if you are willing to at least try it out!

That's an interesting suggestion. I'll create an issue and we can figure it out there. Thanks!

@sobolevnrm
Copy link
Member Author

@kiyoon How do I catch the ruff errors in the build above before committing? I ran

ruff format --check --diff --config pyproject.toml .

but it didn't catch the ones flagged in the build/test.

@sobolevnrm
Copy link
Member Author

@kiyoon How do I catch the ruff errors in the build above before committing? I ran

ruff format --check --diff --config pyproject.toml .

but it didn't catch the ones flagged in the build/test.

Never mind: ruff check --select I --diff --config pyproject.toml . works.

@kiyoon
Copy link
Collaborator

kiyoon commented Dec 30, 2024

I didn't fix all of the lint errors yet, and they still need to be addressed.

In fact, there are some errors I don't like as much, and it really depends on the project so we should discuss which to ignore further.

But you can treat most errors more like a development guide, not something that must pass. Switching on the diagnostics help you write cleaner code in general.

The --select I means you selected isort errors, which you should apply before publishing because it's easy to.

The --config pyproject.toml is redundant as it will by default select from there.

If you set --config ruff_essential.toml it grabs all the syntax errors that must pass.

@kiyoon
Copy link
Collaborator

kiyoon commented Dec 30, 2024

Fixing isort error is something like ruff check --select I --fix .

@sobolevnrm
Copy link
Member Author

Yes, some of the errors seem overly pedantic and we should discuss. Thanks!

@sobolevnrm sobolevnrm requested a review from kiyoon December 30, 2024 03:52
@sobolevnrm sobolevnrm merged commit 9dd79cb into master Dec 30, 2024
6 checks passed
@sobolevnrm sobolevnrm deleted the nathan/371 branch December 30, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update docutils please?
2 participants