Migrate to first pre-release of FFI 0.9.0 #1446
Conversation
| @@ -56,6 +56,7 @@ actor CompactBlockProcessor { | |||
| let saplingParamsSourceURL: SaplingParamsSourceURL | |||
| let fsBlockCacheRoot: URL | |||
| let dataDb: URL | |||
| let torDir: URL | |||
There was a problem hiding this comment.
I feel like there are now too many of these; I originally was passing this through to ZcashRustBackend, but now have a separate TorClient that only the SDKSynchronizer needs to know about. But I didn't have time to figure out which of these could be reverted.
There was a problem hiding this comment.
Agreed but not high-prio to deal with it right now I believe. We can file a followup ticket to maybe pass a URLConfiguration or something like that.
| @@ -823,33 +847,33 @@ struct ZcashRustBackend: ZcashRustBackendWelding { | |||
| } | |||
|
|
|||
| private extension ZcashRustBackend { | |||
| static func enableTracing() { | |||
| zcashlc_init_on_load(false) | |||
There was a problem hiding this comment.
The old code here was treating the enableTracing argument to ZcashRustBackend as enabling Rust logging, rather than enabling trace-level logging. The changes I've made so far in this PR have preserved that, but only because OSLogger.LogLevel has no trace level.
str4d
force-pushed
the
rust-logging-and-exchange-rates
branch
from
ea54bf1 to
fca9729
Compare
str4d
force-pushed
the
rust-logging-and-exchange-rates
branch
from
fca9729 to
929f198
Compare
|
Force-pushed to address comments, and replace |
Includes: - Initialization changes to enable log filter customization. We now connect the Rust log level to the Swift log level, and always run other Rust initialization steps. - ZIP 320 support (TEX addresses).
str4d
force-pushed
the
rust-logging-and-exchange-rates
branch
from
929f198 to
bce8085
Compare
|
Rebased on latest integration branch state and pulled in latest -ffi preview state. |
- API refactored to Combine's CurrentValueSubject refresh-rate - FiatCurrencyResult is now Equatable refresh-rates - cleanup refresh-rates - The API has been refactored to follow the same principles as for state and events. - Review comments addressed refresh-rates - The API has been extended to send a result of the operation, success or failure refresh-rates - bugfix of the try vs try? refresh-rates - reverted the error state Update CHANGELOG.md - changelog updated
Co-authored-by: Jack Grigg <[email protected]>
refresh-rates
- The API has been refactored to carry state and always broadcast a value, even in case of failed request always-return-value - ignore refresh request when one is already in flight always-return-value - ensure tor client is initialized always-return-value - don't pass nil value always-return-value - final touch, the tor initialization is sligthly more controlled and error potentially propagated.
always-return-value
- comments addressed
comments-fixed
| // Compiled from 2516a94f8bdc540d951c38b66e9c07e2b8c29cb4 | ||
| .package(url: "https://github.com/zcash-hackworks/zcash-light-client-ffi", revision: "4de1b42f99aebfc5e4f0340da8a66a4f719db9a6") |
There was a problem hiding this comment.
I've confirmed that the "compiled from" commit is present in Electric-Coin-Company/zcash-light-client-ffi#143, and the current target is the tip commit of https://github.com/Electric-Coin-Company/zcash-light-client-ffi/tree/ffi-preview-0.9.0 (which will be deleted once we're ready to release FFI 0.9.0, but will preserve the individual target commits within the feature branch for now).
Includes:
Depends on Electric-Coin-Company/zcash-light-client-ffi#142.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer